Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-8390

<framework custom="false"/> broken for gradle projects

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      <framework custom=false>
      

      allows referencing of android support libraries and play services, which live within the user's SDK directory.

      https://developer.android.com/tools/support-library/features.html

      There is currently ANT-specific logic within plugman to handle them, and they don't work at all for gradle projects.

      https://github.com/apache/cordova-lib/blob/e05c656ef3d77d6c5e9232ed4e6ddbd3e29654eb/cordova-lib/src/plugman/platforms/android.js#L118

      (note the use of local.properties)

      Some example tags:

      <framework src="extras/android/support/v4" />
      <framework src="extras/android/support/v13" />
      <framework src="google/google_play_services/libproject/google-play-services_lib" />
      

      Currently (for ANT), these libraries were added as sub-projects using the path to them within the SDK directory. For gradle, we should be added them via:

      dependencies {
        compile 'com.android.support:support-v4:21.0.+'
        compile 'com.android.support:support-v13:18.0.+'
        compile 'com.google.android.gms:play-services:6.5.87'
      }
      

      Proposed change:

      Look for `src` in the form of `extras/android/support/v4` and map that to `com.android.support:support-v4`. Just use a hardcoded lookup table, as this is just for backwards compat.

      Add support for `src` in the form of `com.android.support:support-v4`, and add these to the project.properties file, in the same way that we do for subprojects and gradleReference frameworks.

        Attachments

          Activity

            People

            • Assignee:
              agrieve Andrew Grieve
              Reporter:
              agrieve Andrew Grieve
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: