Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-8226

'cordova platform add' should look into config.xml for correct engine element when no version is provided

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Master
    • None
    • cordova-lib
    • None

    Description

      When the 'cordova platform add' command is executed with no version specified (e.g: user runs ‘cordova platform add android’ instead of ‘cordova platform add android@3.6.4’), cordova-lib should look at the config.xml file for the correct <engine> element and use its version. It should default to using the pinned version if there is no corresponding <engine> element in the config.xml file.

      For example, if the user enters : 'cordova platform add android' and the config.xml file contains this entry: <cdv:engine id="android" version="file://C:/folder/to/android/platform" />, We should use the specified folder's bin/create scripts to add the android platform, not the default version.

      The engine element in config.xml could be one of the following form :

      1- <cdv:engine id="android" version="3.6.0" />
      2- <cdv:engine id="android" version="file://C:/folder/to/android/platform" />

      Attachments

        Activity

          People

            omefire Omar Mefire
            omefire Omar Mefire
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 48h
                48h
                Remaining:
                Remaining Estimate - 48h
                48h
                Logged:
                Time Spent - Not Specified
                Not Specified