Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-8056

Implement splashscreen for Windows platform

    Details

      Description

      config.xml
      <preference name="SplashScreen" value="splash"/>
      <preference name="SplashScreenDelay" value="10000" />
      <preference name="AutoHideSplashScreen" value="false" />
      

      This has no effect on the cordova-windows platform. Splash screen autohides after <1000ms.

      Tested on WP 8.1.

      Let me know if there's any other information I can provide. The documentation for splash screens on 8.1 seems to be somewhat lacking, so I may have missed something somewhere.

        Issue Links

          Activity

          Hide
          andresz Andres Zsogon added a comment -

          Hi, how can I check if this was fixed on a new version so I update the WP8 platform to that version? There are too many versions after 3.6.3 and I have no clue how to choose a version, or if this issue was or wasn't fixed. Thanks.

          Show
          andresz Andres Zsogon added a comment - Hi, how can I check if this was fixed on a new version so I update the WP8 platform to that version? There are too many versions after 3.6.3 and I have no clue how to choose a version, or if this issue was or wasn't fixed. Thanks.
          Hide
          chtsch Christian Tschanz added a comment -

          Hi, I tried to get the SplashScreen Plugin (v3.0.0) to work on an WinPhone 8.1 Universal App (Cordova Windows 4.2.0, Cordova 5.4.1) but it didn't work.
          I get the SplashScreen when the app is launched but as soon as the app starts to load, I get a white screen until the app is loaded.
          On iOS & Android it works just fine to manually hide it afterwards.
          It would be great if someone could look into this.

          Show
          chtsch Christian Tschanz added a comment - Hi, I tried to get the SplashScreen Plugin (v3.0.0) to work on an WinPhone 8.1 Universal App (Cordova Windows 4.2.0, Cordova 5.4.1) but it didn't work. I get the SplashScreen when the app is launched but as soon as the app starts to load, I get a white screen until the app is loaded. On iOS & Android it works just fine to manually hide it afterwards. It would be great if someone could look into this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user daserge opened a pull request:

          https://github.com/apache/cordova-windows/pull/141

          CB-8056 Implement splashscreen for Windows platform

          [Jira issue](https://issues.apache.org/jira/browse/CB-8056)

          Moved the implementation to the platform as per plugins triage recommendation and due to `ui.js` and `WinJS.UI.processAll();` are required for Windows Phone implementation as it uses `data-win-control="WinJS.UI.ViewBox"`.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-windows CB-8056

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-windows/pull/141.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #141


          commit 03a6d8d45db68ac98b9209c4ffc231affb1cadef
          Author: daserge <v-seshak@microsoft.com>
          Date: 2016-01-20T19:00:56Z

          CB-8056 Implement splashscreen for Windows platform


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/141 CB-8056 Implement splashscreen for Windows platform [Jira issue] ( https://issues.apache.org/jira/browse/CB-8056 ) Moved the implementation to the platform as per plugins triage recommendation and due to `ui.js` and `WinJS.UI.processAll();` are required for Windows Phone implementation as it uses `data-win-control="WinJS.UI.ViewBox"`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-8056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 03a6d8d45db68ac98b9209c4ffc231affb1cadef Author: daserge <v-seshak@microsoft.com> Date: 2016-01-20T19:00:56Z CB-8056 Implement splashscreen for Windows platform
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user daserge opened a pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76

          CB-8056 Implement splashscreen for Windows platform

          [Jira issue](https://issues.apache.org/jira/browse/CB-8056)

          The plugin implementation has been moved to the platform code
          Documented SplashScreenBackgroundColor preference for Windows
          Updated the docs

          Related to apache/cordova-windows#141

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #76


          commit 5ffb4cb771b11bffc0c4f6a707563b20e7d19613
          Author: daserge <v-seshak@microsoft.com>
          Date: 2016-01-14T16:15:06Z

          CB-8056 Implement splashscreen for Windows platform

          The plugin implementation has been moved to the platform code
          Documented SplashScreenBackgroundColor preference for Windows
          Updated the docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76 CB-8056 Implement splashscreen for Windows platform [Jira issue] ( https://issues.apache.org/jira/browse/CB-8056 ) The plugin implementation has been moved to the platform code Documented SplashScreenBackgroundColor preference for Windows Updated the docs Related to apache/cordova-windows#141 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 5ffb4cb771b11bffc0c4f6a707563b20e7d19613 Author: daserge <v-seshak@microsoft.com> Date: 2016-01-14T16:15:06Z CB-8056 Implement splashscreen for Windows platform The plugin implementation has been moved to the platform code Documented SplashScreenBackgroundColor preference for Windows Updated the docs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user purplecabbage commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-173398203

          Is there a link to the conversation around this change? ( I assume it is [1] )
          Ultimately there are 2 pieces to splash-screen :
          1. the platform/os splash screen built into every app
          2. the cordova specific plugin which processes preferences

          My understanding is that if you do NOT have the plugin installed, then the platform/os splash is presented and dismissed automatically once the app has launched. The image(s) used for this can and should be controlled by preferences in config.xml and this should be done at build time, moving files, renaming files, modifying app manifests, ...

          If the splash-screen plugin is installed, we gain the ability to delay dismissing the splash screen ( by emulating it with a full screen image which quickly replaces the platform/os version )

          This is the way things are currently, and I DO completely support moving splash-screen management back into the platforms so it can be processed before plugins are loaded, I just want to make sure that we are moving on this for all platforms and that there has been enough discussion/agreement around it.
          I think I expected that each of the plugin audit proposals should spawn it's own detailed proposal, but I may be over administering things. As long as we all agree that this is the way forward, and this will be done for all platforms; +1

          [1] https://github.com/cordova/cordova-discuss/pull/28/files#diff-e1c3c74bda464d02680ae112f2927180R175

          Show
          githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-173398203 Is there a link to the conversation around this change? ( I assume it is [1] ) Ultimately there are 2 pieces to splash-screen : 1. the platform/os splash screen built into every app 2. the cordova specific plugin which processes preferences My understanding is that if you do NOT have the plugin installed, then the platform/os splash is presented and dismissed automatically once the app has launched. The image(s) used for this can and should be controlled by preferences in config.xml and this should be done at build time, moving files, renaming files, modifying app manifests, ... If the splash-screen plugin is installed, we gain the ability to delay dismissing the splash screen ( by emulating it with a full screen image which quickly replaces the platform/os version ) This is the way things are currently, and I DO completely support moving splash-screen management back into the platforms so it can be processed before plugins are loaded, I just want to make sure that we are moving on this for all platforms and that there has been enough discussion/agreement around it. I think I expected that each of the plugin audit proposals should spawn it's own detailed proposal, but I may be over administering things. As long as we all agree that this is the way forward, and this will be done for all platforms; +1 [1] https://github.com/cordova/cordova-discuss/pull/28/files#diff-e1c3c74bda464d02680ae112f2927180R175
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-174487439

          @purplecabbage, thanks for reviewing!

          The main reason to move the code to the platform was the need to hook into activated event so that the initial splash image could be delayed until the plugin is configured.

          I'm not sure when/if other platforms are going to be rewritten in this way.

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-174487439 @purplecabbage, thanks for reviewing! The main reason to move the code to the platform was the need to hook into activated event so that the initial splash image could be delayed until the plugin is configured. I'm not sure when/if other platforms are going to be rewritten in this way.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user SunboX commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-175494339

          That's great! Just was looking for a way how to set the background color for UWP splash screen (Windows 10 Mobile). Thanks for your work! :+1: :heart:

          Show
          githubbot ASF GitHub Bot added a comment - Github user SunboX commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-175494339 That's great! Just was looking for a way how to set the background color for UWP splash screen (Windows 10 Mobile). Thanks for your work! :+1: :heart:
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user SunboX commented on a diff in the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50958608

          — Diff: README.md —
          @@ -123,13 +123,26 @@ window.setTimeout(function () {
          }, splashDuration - fadeDuration);
          ```

                1. iOS Quirks
                  +### iOS and Windows Quirks
          • `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false`
            to hide the splash-screen spinner.

          <preference name="ShowSplashScreenSpinner" value="false"/>

          +### Windows Quirks
          +
          +- `SplashScreenSpinnerColor` (string, defaults to system accent color): hash, rgb notation or CSS color name.
          +
          + <preference name="SplashScreenSpinnerColor" value="#242424"/>
          + <preference name="SplashScreenSpinnerColor" value="DarkRed"/>
          + <preference name="SplashScreenSpinnerColor" value="rgb(50,128,128)"/>
          +
          +- `SplashScreenBackgroundColor` (string, defaults to #464646): hex notation.
          +
          + <preference name="SplashScreenBackgroundColor" value="0xFFFFFFFF"/>
          +
          +
          — End diff –

          Shouldn't it be mentioned to add "Scale 100", "Scale 140" and "Scale 180" images? (620 x 300 px, 868 x 420 px and 1116 x 540 px, https://msdn.microsoft.com/en-us/library/windows/apps/mt187306.aspx)

          Show
          githubbot ASF GitHub Bot added a comment - Github user SunboX commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50958608 — Diff: README.md — @@ -123,13 +123,26 @@ window.setTimeout(function () { }, splashDuration - fadeDuration); ``` iOS Quirks +### iOS and Windows Quirks `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false` to hide the splash-screen spinner. <preference name="ShowSplashScreenSpinner" value="false"/> +### Windows Quirks + +- `SplashScreenSpinnerColor` (string, defaults to system accent color): hash, rgb notation or CSS color name. + + <preference name="SplashScreenSpinnerColor" value="#242424"/> + <preference name="SplashScreenSpinnerColor" value="DarkRed"/> + <preference name="SplashScreenSpinnerColor" value="rgb(50,128,128)"/> + +- `SplashScreenBackgroundColor` (string, defaults to #464646): hex notation. + + <preference name="SplashScreenBackgroundColor" value="0xFFFFFFFF"/> + + — End diff – Shouldn't it be mentioned to add "Scale 100", "Scale 140" and "Scale 180" images? (620 x 300 px, 868 x 420 px and 1116 x 540 px, https://msdn.microsoft.com/en-us/library/windows/apps/mt187306.aspx )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on a diff in the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50966450

          — Diff: README.md —
          @@ -123,13 +123,26 @@ window.setTimeout(function () {
          }, splashDuration - fadeDuration);
          ```

                1. iOS Quirks
                  +### iOS and Windows Quirks
          • `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false`
            to hide the splash-screen spinner.

          <preference name="ShowSplashScreenSpinner" value="false"/>

          +### Windows Quirks
          +
          +- `SplashScreenSpinnerColor` (string, defaults to system accent color): hash, rgb notation or CSS color name.
          +
          + <preference name="SplashScreenSpinnerColor" value="#242424"/>
          + <preference name="SplashScreenSpinnerColor" value="DarkRed"/>
          + <preference name="SplashScreenSpinnerColor" value="rgb(50,128,128)"/>
          +
          +- `SplashScreenBackgroundColor` (string, defaults to #464646): hex notation.
          +
          + <preference name="SplashScreenBackgroundColor" value="0xFFFFFFFF"/>
          +
          +
          — End diff –

          @SunboX, thanks, there is a separate issue for that: https://issues.apache.org/jira/browse/CB-9287

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50966450 — Diff: README.md — @@ -123,13 +123,26 @@ window.setTimeout(function () { }, splashDuration - fadeDuration); ``` iOS Quirks +### iOS and Windows Quirks `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false` to hide the splash-screen spinner. <preference name="ShowSplashScreenSpinner" value="false"/> +### Windows Quirks + +- `SplashScreenSpinnerColor` (string, defaults to system accent color): hash, rgb notation or CSS color name. + + <preference name="SplashScreenSpinnerColor" value="#242424"/> + <preference name="SplashScreenSpinnerColor" value="DarkRed"/> + <preference name="SplashScreenSpinnerColor" value="rgb(50,128,128)"/> + +- `SplashScreenBackgroundColor` (string, defaults to #464646): hex notation. + + <preference name="SplashScreenBackgroundColor" value="0xFFFFFFFF"/> + + — End diff – @SunboX, thanks, there is a separate issue for that: https://issues.apache.org/jira/browse/CB-9287
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chrigi commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176245101

          Thanks for your work. I noticed the following:

          • It does not respect the "ShowSplashScreenSpinner" preference from the config.xml
          • The spinner seems to slightly overlap the image
          • It does not set the statusbar color to the splashScreenBackgroundColor when calling .show() and restore the previous color when calling .hide() and when setting the statusbar color before hiding the splash screen it will change the color. This will probably need adjustments in the status bar plugin I think.

          But I can absolutely use it like this. Thanks a LOT!

          Show
          githubbot ASF GitHub Bot added a comment - Github user chrigi commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176245101 Thanks for your work. I noticed the following: It does not respect the "ShowSplashScreenSpinner" preference from the config.xml The spinner seems to slightly overlap the image It does not set the statusbar color to the splashScreenBackgroundColor when calling .show() and restore the previous color when calling .hide() and when setting the statusbar color before hiding the splash screen it will change the color. This will probably need adjustments in the status bar plugin I think. But I can absolutely use it like this. Thanks a LOT!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176310415

          @chrigi, thanks for your feedback.

          > It does not respect the "ShowSplashScreenSpinner" preference from the config.xml

          That's strange, it should - I will take a look this weekend.

          > The spinner seems to slightly overlap the image

          Which platform(s) has this issue? (wp8.1, wp10, win8.1, win10)
          What screen size/resolution?

          > It does not set the statusbar color to the splashScreenBackgroundColor

          That's a good point, thanks, I will also try to look into this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176310415 @chrigi, thanks for your feedback. > It does not respect the "ShowSplashScreenSpinner" preference from the config.xml That's strange, it should - I will take a look this weekend. > The spinner seems to slightly overlap the image Which platform(s) has this issue? (wp8.1, wp10, win8.1, win10) What screen size/resolution? > It does not set the statusbar color to the splashScreenBackgroundColor That's a good point, thanks, I will also try to look into this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chrigi commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-178437613

          @daserge
          I tried it on Windows Mobile 10 (windows engine) Lumia 950 XL.

          Show
          githubbot ASF GitHub Bot added a comment - Github user chrigi commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-178437613 @daserge I tried it on Windows Mobile 10 (windows engine) Lumia 950 XL.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user SunboX commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-194337561

          Two comments on this:

          • calling `navigator.splashscreen.hide();` does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10)
          • calling `StatusBar.show();` should not show the status bar while the splash screen is shown (and should show the status bar automatically after the splash screen gets hidden)
          Show
          githubbot ASF GitHub Bot added a comment - Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-194337561 Two comments on this: calling `navigator.splashscreen.hide();` does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10) calling `StatusBar.show();` should not show the status bar while the splash screen is shown (and should show the status bar automatically after the splash screen gets hidden)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user SunboX commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-194745886

          > * calling navigator.splashscreen.hide(); does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10)

          Ok, this was my fault. I had the splashscreen plugin installed additionally. Removed it, now it works as expected. Thanks for your work!

          Show
          githubbot ASF GitHub Bot added a comment - Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-194745886 > * calling navigator.splashscreen.hide(); does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10) Ok, this was my fault. I had the splashscreen plugin installed additionally. Removed it, now it works as expected. Thanks for your work!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user purplecabbage commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-205929216

          This now has conflicts, can we get a rebase and a merge? lgtm!

          Show
          githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-205929216 This now has conflicts, can we get a rebase and a merge? lgtm!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-213475272

          @SunboX, @chrigi, I've rebased and updated the PRs, could you please try how it works for you?
          `cordova platform add https://github.com/MSOpenTech/cordova-windows#d6988f5c863ec3ba5cde33a678a4b93badc64395`
          `cordova plugin add https://github.com/MSOpenTech/cordova-plugin-splashscreen#acb45f3a386bbb80d1d52cbe9d26f3de2617bfe0`

          Sample config.xml:
          ```
          <preference name="SplashScreenBackgroundColor" value="#292826" />
          <preference name="SplashScreenSpinnerColor" value="#d03932" />

          <preference name="FadeSplashScreenDuration" value="500" />

          <preference name="AutoHideSplashScreen" value="true" />

          <preference name="FadeSplashScreen" value="true" />

          <preference name="SplashScreenDelay" value="2500" />

          <platform name="windows">
          <!-- images are determined by width and height. The following are supported -->
          <splash src="res/screen/windows/splashscreen.png" width="620" height="300"/>
          <splash src="res/screen/windows/splashscreenphone.png" width="1152" height="1920"/>
          </platform>
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-213475272 @SunboX, @chrigi, I've rebased and updated the PRs, could you please try how it works for you? `cordova platform add https://github.com/MSOpenTech/cordova-windows#d6988f5c863ec3ba5cde33a678a4b93badc64395 ` `cordova plugin add https://github.com/MSOpenTech/cordova-plugin-splashscreen#acb45f3a386bbb80d1d52cbe9d26f3de2617bfe0 ` Sample config.xml: ``` <preference name="SplashScreenBackgroundColor" value="#292826" /> <preference name="SplashScreenSpinnerColor" value="#d03932" /> <preference name="FadeSplashScreenDuration" value="500" /> <preference name="AutoHideSplashScreen" value="true" /> <preference name="FadeSplashScreen" value="true" /> <preference name="SplashScreenDelay" value="2500" /> <platform name="windows"> <!-- images are determined by width and height. The following are supported --> <splash src="res/screen/windows/splashscreen.png" width="620" height="300"/> <splash src="res/screen/windows/splashscreenphone.png" width="1152" height="1920"/> </platform> ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-213476651

          @chrigi, note that I haven't addressed this:

          > It does not set the statusbar color to the splashScreenBackgroundColor

          I will file a separate issue for this when the PRs are merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-213476651 @chrigi, note that I haven't addressed this: > It does not set the statusbar color to the splashScreenBackgroundColor I will file a separate issue for this when the PRs are merged.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit acb45f3a386bbb80d1d52cbe9d26f3de2617bfe0 in cordova-plugin-splashscreen's branch refs/heads/master from Sergey Shakhnazarov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=acb45f3 ]

          CB-8056 Implement splashscreen for Windows platform

          The plugin implementation has been moved to the platform code
          Documented SplashScreenBackgroundColor preference for Windows
          Updated the docs
          Updated plugin dependencies - cordova-windows@5 is required
          Updated the plugin version to 4.0.0

          Show
          jira-bot ASF subversion and git services added a comment - Commit acb45f3a386bbb80d1d52cbe9d26f3de2617bfe0 in cordova-plugin-splashscreen's branch refs/heads/master from Sergey Shakhnazarov [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=acb45f3 ] CB-8056 Implement splashscreen for Windows platform The plugin implementation has been moved to the platform code Documented SplashScreenBackgroundColor preference for Windows Updated the docs Updated plugin dependencies - cordova-windows@5 is required Updated the plugin version to 4.0.0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/76
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d6988f5c863ec3ba5cde33a678a4b93badc64395 in cordova-windows's branch refs/heads/master from Sergey Shakhnazarov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=d6988f5 ]

          CB-8056 Implement splashscreen for Windows platform

          Updated version to 5.0.0

          Show
          jira-bot ASF subversion and git services added a comment - Commit d6988f5c863ec3ba5cde33a678a4b93badc64395 in cordova-windows's branch refs/heads/master from Sergey Shakhnazarov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=d6988f5 ] CB-8056 Implement splashscreen for Windows platform Updated version to 5.0.0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-windows/pull/141

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/141
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user purplecabbage commented on the pull request:

          https://github.com/apache/cordova-windows/pull/141#issuecomment-213581048

          Verified, and merged. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-213581048 Verified, and merged. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user purplecabbage commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213581077

          Verified, and merged. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213581077 Verified, and merged. Thanks!
          Hide
          purplecabbage Jesse MacFadyen added a comment -

          Merged and verified. Thanks Sergey Shakhnazarov

          Show
          purplecabbage Jesse MacFadyen added a comment - Merged and verified. Thanks Sergey Shakhnazarov
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user RobPosener commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213588273

          Spinner has never worked in Windows 10
          It should.

          Show
          githubbot ASF GitHub Bot added a comment - Github user RobPosener commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213588273 Spinner has never worked in Windows 10 It should.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user purplecabbage commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213589583

          it does

          Show
          githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213589583 it does
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user daserge commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213673802

          @RobPosener, did the issue happen for you in the old or in the current version?
          On Windows 10 Mobile or Desktop?
          Have you tried to change the spinner color?
          `<preference name="SplashScreenSpinnerColor" value="#d03932" />`

          Show
          githubbot ASF GitHub Bot added a comment - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213673802 @RobPosener, did the issue happen for you in the old or in the current version? On Windows 10 Mobile or Desktop? Have you tried to change the spinner color? `<preference name="SplashScreenSpinnerColor" value="#d03932" />`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user RobPosener commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213675499

          I've been developing for the Android platform since January 2014 (and the
          splash screen spinner now works there) and the Windows platform (on a
          desktop Windows 10) using Visual Studio 2015 (now with Update 2) since
          October, 2015 and the splash screen spinner has never worked for the
          Windows platform. I've tried a few variations in my config.xml file over
          the months but have never been able to get the spinner to work.
          FYI, my complete config.xml for windows platform parameters are:

          <platform name="windows"> <icon height="150"
          src="res/icons/windows/Logo.png" width="150" /> <icon height="30"
          src="res/icons/windows/LogoSmall.png" width="30" /> <icon
          height="50" src="res/icons/windows/LogoStore.png" width="50" />
          <icon height="44" src="res/icons/windows/LogoStartScreen.png"
          width="44" /> <splash height="300"
          src="res/screens/windows/SplashScreen-620x300.png" width="620" />
          <splash height="1920"
          src="res/screens/windows/SplashScreen-1152x1920.png" width="1152" />
          <preference name="SplashScreen" value="screen" /> <preference
          name="SplashScreenDelay" value="75000" /> <preference
          name="SplashScreenBackgroundColor" value="0x00000000" />
          <preference name="SplashMaintainAspectRatio" value="true" />
          <preference name="SplashShowOnlyFirstTime" value="false" />
          <preference name="FadeSplashScreen" value="true" /> <preference
          name="FadeSplashScreenDuration" value="1500" /> <preference
          name="ShowSplashScreenSpinner" value="true" /> <preference
          name="SplashScreenSpinnerColor" value="#242424" /> <preference
          name="AutoHideSplashScreen" value="false" /> <preference
          name="windows-target-version" value="10.0" /> <preference
          name="windows-phone-target-version" value="10.0" /> </platform>

          Regards

          Rob

          Regards
          Rob Posener
          0419 012 627

          On 23 April 2016 at 16:22, Sergey Shakhnazarov <notifications@github.com>
          wrote:

          > @RobPosener <https://github.com/RobPosener>, did the issue happen for you
          > in the old or in the current version?
          > On Windows 10 Mobile or Desktop?
          > Have you tried to change the spinner color?
          > <preference name="SplashScreenSpinnerColor" value="#d03932" />
          >
          > —
          > You are receiving this because you were mentioned.
          > Reply to this email directly or view it on GitHub
          > <https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213673802>
          >

          Show
          githubbot ASF GitHub Bot added a comment - Github user RobPosener commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213675499 I've been developing for the Android platform since January 2014 (and the splash screen spinner now works there) and the Windows platform (on a desktop Windows 10) using Visual Studio 2015 (now with Update 2) since October, 2015 and the splash screen spinner has never worked for the Windows platform. I've tried a few variations in my config.xml file over the months but have never been able to get the spinner to work. FYI, my complete config.xml for windows platform parameters are: <platform name="windows"> <icon height="150" src="res/icons/windows/Logo.png" width="150" /> <icon height="30" src="res/icons/windows/LogoSmall.png" width="30" /> <icon height="50" src="res/icons/windows/LogoStore.png" width="50" /> <icon height="44" src="res/icons/windows/LogoStartScreen.png" width="44" /> <splash height="300" src="res/screens/windows/SplashScreen-620x300.png" width="620" /> <splash height="1920" src="res/screens/windows/SplashScreen-1152x1920.png" width="1152" /> <preference name="SplashScreen" value="screen" /> <preference name="SplashScreenDelay" value="75000" /> <preference name="SplashScreenBackgroundColor" value="0x00000000" /> <preference name="SplashMaintainAspectRatio" value="true" /> <preference name="SplashShowOnlyFirstTime" value="false" /> <preference name="FadeSplashScreen" value="true" /> <preference name="FadeSplashScreenDuration" value="1500" /> <preference name="ShowSplashScreenSpinner" value="true" /> <preference name="SplashScreenSpinnerColor" value="#242424" /> <preference name="AutoHideSplashScreen" value="false" /> <preference name="windows-target-version" value="10.0" /> <preference name="windows-phone-target-version" value="10.0" /> </platform> Regards Rob Regards Rob Posener 0419 012 627 On 23 April 2016 at 16:22, Sergey Shakhnazarov <notifications@github.com> wrote: > @RobPosener < https://github.com/RobPosener >, did the issue happen for you > in the old or in the current version? > On Windows 10 Mobile or Desktop? > Have you tried to change the spinner color? > <preference name="SplashScreenSpinnerColor" value="#d03932" /> > > — > You are receiving this because you were mentioned. > Reply to this email directly or view it on GitHub > < https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213673802 > >
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bbd8de71dbfa8c3b03f5e67c60a63f6818ca42eb in cordova-windows's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=bbd8de7 ]

          CB-8056 Revert version that was mistakengly changed in d6988f5c

          Show
          jira-bot ASF subversion and git services added a comment - Commit bbd8de71dbfa8c3b03f5e67c60a63f6818ca42eb in cordova-windows's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=bbd8de7 ] CB-8056 Revert version that was mistakengly changed in d6988f5c
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user daserge opened a pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/100

          CB-8056 Updated the dependency version, added it to the docs

          Related to https://github.com/apache/cordova-windows/pull/172

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-splashscreen/pull/100.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #100


          commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a
          Author: daserge <v-seshak@microsoft.com>
          Date: 2016-04-29T13:26:20Z

          CB-8056 Updated the dependency version, added it to the docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/100 CB-8056 Updated the dependency version, added it to the docs Related to https://github.com/apache/cordova-windows/pull/172 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a Author: daserge <v-seshak@microsoft.com> Date: 2016-04-29T13:26:20Z CB-8056 Updated the dependency version, added it to the docs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rakatyal commented on the pull request:

          https://github.com/apache/cordova-plugin-splashscreen/pull/100#issuecomment-215833256

          LGTM.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/100#issuecomment-215833256 LGTM.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a in cordova-plugin-splashscreen's branch refs/heads/master from Sergey Shakhnazarov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=3d924fc ]

          CB-8056 Updated the dependency version, added it to the docs

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a in cordova-plugin-splashscreen's branch refs/heads/master from Sergey Shakhnazarov [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=3d924fc ] CB-8056 Updated the dependency version, added it to the docs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-plugin-splashscreen/pull/100

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/100

            People

            • Assignee:
              daserge Sergey Shakhnazarov
              Reporter:
              dougestey Doug Estey
            • Votes:
              5 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development