[CB-7767] [iOS] Remove usage of NSData+Base64

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: cordova-ios
• Assignee: Shazron Abdullah
• Reporter: Shazron Abdullah
• Created: 10/Oct/14 23:42
• Updated: 23/Aug/18 07:10
• Resolved: 19/Mar/15 00:39

Description

There is built in support since iOS 7. Once we drop iOS 6, we can do this.

https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/index.html#//apple_ref/doc/uid/20000172-SW36

Lines:
1. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVInvokedUrlCommand.m#L88
2. https://github.com/apache/cordova-ios/blob/1a44a4eed9f22024cc0480733a4c21af63f92ab5/CordovaLib/Classes/CDVPluginResult.m#L40

Replace with:
1. [[NSData alloc] initWithBase64EncodedString:data options:0]
2. [data base64EncodedStringWithOptions:0]

Test mobilespec bridge benchmark before this change and after, then report the results.

Issue Links

• depends upon: CB-8643 Drop iOS 6 support, minimum iOS 7