[CB-7643] sendPluginResult is not thread safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.7.0
• Component/s: cordova-ios
• Assignee: Shazron Abdullah
• Reporter: Richard Hermanson
• Created: 25/Sep/14 22:25
• Updated: 23/Aug/18 07:17
• Resolved: 17/Oct/14 01:42

Description

If _callbackIdPattern in CVDCommandDelegateImpl.m is set at the same time as it is used (in different threads) then there's an error thrown (EXC_BAD_ACCESS).

More precisely when this line is run in one thread:
_callbackIdPattern = [NSRegularExpression regularExpressionWithPattern:@"[^A-Za-z0-9._-]" options:0 error:&err];

and this in another:
if (([callbackId length] > 100) || [_callbackIdPattern firstMatchInString:callbackId options:0 range:NSMakeRange(0, [callbackId length])]) {

The method is: - (BOOL)isValidCallbackId:(NSString *)callbackId

This happens about every 10th time I start my application. I could surely solve this by not calling too quickly and repeatedly but this is still a bug and easily fixed.