[CB-7602] isCopyOnItself check returns invalid result when moving directory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Component/s: cordova-android, cordova-plugin-file
• Labels: copyTo moveTo
• Assignee: Ian Clelland
• Reporter: Tom Good
• Created: 19/Sep/14 17:53
• Updated: 23/Aug/18 07:18
• Resolved: 11/Nov/14 18:10

Description

When using moveTo to move a directory the isCopyOnItself check fails if the directory name starts the same but is different. Example:

Source:
/storage/emulated/0/GalileoMobile
Destination:
/storage/emulated/0/GalileoMobileBackup/GalileoMobile

The issue is with the indexof check looking for any slash following the partial match.

Existing Line 305 of LocalFileSystem.java:
if (dest.startsWith(src) && dest.indexOf(File.separator, src.length() - 1) != -1) {

Something like this should work:
if (dest.equals(src) || dest.startsWith(src + File.separator) ) {

This would also occur with copies.