Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-7367

Allow update of weinreId without page refresh

    Details

    • Type: Wish
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-weinre
    • Labels:
      None

      Description

      As the clientId is specified in the URL's fragment, browsers will not refresh the page when changing the clientId from Weinre.
      Detect changes to the fragment within Weinre to allow updating this on the fly (no page refresh required).

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -
        Show
        githubbot ASF GitHub Bot added a comment - Github user shteou commented on the pull request: https://github.com/apache/cordova-weinre/pull/7#issuecomment-53032403 Issue logged: https://issues.apache.org/jira/browse/CB-7367 Thanks.
        Hide
        pmuellr Patrick Mueller added a comment -

        Did you have any interest in working on a patch? Build directions should be included in the docs.

        No worries, if not. I'll queue it up for sometime next week (hopefully).

        Show
        pmuellr Patrick Mueller added a comment - Did you have any interest in working on a patch? Build directions should be included in the docs. No worries, if not. I'll queue it up for sometime next week (hopefully).
        Hide
        shteou Stewart added a comment -

        Hi Patrick, this is pertaining to a pull request on github (see above). It's just a few lines in the index.js file to support it.
        I performed a development build and tested the change on that output, but couldn't see any tests to run.

        Best regards,
        Stew.

        Show
        shteou Stewart added a comment - Hi Patrick, this is pertaining to a pull request on github (see above). It's just a few lines in the index.js file to support it. I performed a development build and tested the change on that output, but couldn't see any tests to run. Best regards, Stew.
        Hide
        pmuellr Patrick Mueller added a comment -

        Sorry, brain fart there! Got a few things on my mind

        Ya, don't have any tests, sorry.

        Will look at soon, thanks so much!

        Show
        pmuellr Patrick Mueller added a comment - Sorry, brain fart there! Got a few things on my mind Ya, don't have any tests, sorry. Will look at soon, thanks so much!
        Hide
        pmuellr Patrick Mueller added a comment -

        Patch applied, weinre rebuilt.

        Thanks Stewart!

        Show
        pmuellr Patrick Mueller added a comment - Patch applied, weinre rebuilt. Thanks Stewart!
        Show
        pmuellr Patrick Mueller added a comment - commit https://github.com/apache/cordova-weinre/commit/ad3c24fe15d119b6e0a712c061e9269418382692

          People

          • Assignee:
            pmuellr Patrick Mueller
            Reporter:
            shteou Stewart
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development