Apache Cordova
  1. Apache Cordova
  2. CB-6637

Remove deprecated method in CDVWebViewDelegate

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.8.0
    • Component/s: iOS
    • Labels:
      None

      Description

      • (BOOL)request:(NSURLRequest*)newRequest isFragmentIdentifierToRequest:(NSURLRequest*)originalRequest

      Deprecated in 3.5.0 – 3 release policy, means in 3.8.0 it will be removed.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user IvanKarpan opened a pull request:

        https://github.com/apache/cordova-ios/pull/121

        CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated method in CDVWebViewDelegate

        Hello,

        I know this is a small contribution but I wanted to help and so fixed this bug:
        https://issues.apache.org/jira/browse/CB-6637

        I just went through the steps here:
        http://wiki.apache.org/cordova/ContributorWorkflow
        But was not able to assign the issue in JIRA to myself.

        Please let me know if I did something incorrectly, if yes - will do better next time. I hope to be more active in Cordova/iOS projects so this is a first step for me.

        Best regards,
        Ivan Karpan

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/IvanKarpan/cordova-ios master

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/cordova-ios/pull/121.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #121


        commit 8f3ef668c604c04030668bab68dfa90c86c7949a
        Author: Ivan Karpan <ivan.karpan@gmail.com>
        Date: 2014-12-08T14:59:21Z

        CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated
        method in CDVWebViewDelegate


        Show
        ASF GitHub Bot added a comment - GitHub user IvanKarpan opened a pull request: https://github.com/apache/cordova-ios/pull/121 CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated method in CDVWebViewDelegate Hello, I know this is a small contribution but I wanted to help and so fixed this bug: https://issues.apache.org/jira/browse/CB-6637 I just went through the steps here: http://wiki.apache.org/cordova/ContributorWorkflow But was not able to assign the issue in JIRA to myself. Please let me know if I did something incorrectly, if yes - will do better next time. I hope to be more active in Cordova/iOS projects so this is a first step for me. Best regards, Ivan Karpan You can merge this pull request into a Git repository by running: $ git pull https://github.com/IvanKarpan/cordova-ios master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 8f3ef668c604c04030668bab68dfa90c86c7949a Author: Ivan Karpan <ivan.karpan@gmail.com> Date: 2014-12-08T14:59:21Z CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated method in CDVWebViewDelegate
        Hide
        ASF GitHub Bot added a comment -

        Github user IvanKarpan commented on the pull request:

        https://github.com/apache/cordova-ios/pull/121#issuecomment-66657870

        Just FYI I received the acknowledgment regarding my ICLA. So my contribution can be officially reviewed and accepted (or rejected but let me know what I should fix).

        Show
        ASF GitHub Bot added a comment - Github user IvanKarpan commented on the pull request: https://github.com/apache/cordova-ios/pull/121#issuecomment-66657870 Just FYI I received the acknowledgment regarding my ICLA. So my contribution can be officially reviewed and accepted (or rejected but let me know what I should fix).
        Hide
        ASF subversion and git services added a comment -

        Commit ea2a9467912ea503360c26a867ede4311fe1a3c1 in cordova-ios's branch refs/heads/master from Ivan Karpan
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=ea2a946 ]

        CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated method in CDVWebViewDelegate (closes #121)

        Signed-off-by: Shazron Abdullah <shazron@apache.org>

        Show
        ASF subversion and git services added a comment - Commit ea2a9467912ea503360c26a867ede4311fe1a3c1 in cordova-ios's branch refs/heads/master from Ivan Karpan [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=ea2a946 ] CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated method in CDVWebViewDelegate (closes #121) Signed-off-by: Shazron Abdullah <shazron@apache.org>
        Hide
        ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/cordova-ios/pull/121

        Show
        ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/121
        Hide
        Shazron Abdullah added a comment -

        Congrats on your first Cordova patch Ivan!

        Show
        Shazron Abdullah added a comment - Congrats on your first Cordova patch Ivan!

          People

          • Assignee:
            Ivan Karpan
            Reporter:
            Shazron Abdullah
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development