[CB-6383] copy-www-build-step.sh is missing a path separator in the destination

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Component/s: cordova-ios
• Assignee: Andrew Grieve
• Reporter: Joshua Perry
• Created: 01/Apr/14 15:30
• Updated: 23/Aug/18 07:17
• Resolved: 16/Apr/14 19:44

Description

In copy-www-build-step.sh anywhere that it generates the `subpath` variable it is removing a required path separator.

For example:

SRC_DIR="www/"
DST_DIR="$BUILT_PRODUCTS_DIR/$FULL_PRODUCT_NAME/www"

#... snip ...

for p in $(do_find -type d -print); do
  subpath="${p#$SRC_DIR}"
  mkdir "$DST_DIR$subpath" || exit 1
done

This will find directories like www/js/, and www/css/.

The subpath=${p#$SRC_DIR} turns these paths into js/ and css/.

In the 3rd line, the mkdir command is taking the DST_DIR and concatenating it with subpath... Well, DST_DIR does not end with a directory separator, and subpath does not start with one. So you get a path like /Users/josh/dev/pdk/idsuck/platforms/ios/build/emulator/HelloWorld.app/wwwjs/ when what you really want is /Users/josh/dev/pdk/idsuck/platforms/ios/build/emulator/HelloWorld.app/www/js/

This issue afflicts all 3 places where subpath is generated in the file.