Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.0
    • Component/s: cordova-plugman
    • Labels:
      None

      Description

      reason:
      No xml_helpers defined ( in src/platforms/firefoxos.js)

        Issue Links

          Activity

          Hide
          Steckelfisch Gert-Jan Braas added a comment - - edited

          the log:
          braas@chickenrun:~/projects/ligplekkenonderweg/LPOWC$ cordova plugin add org.apache.cordova.dialogs
          Fetching plugin "org.apache.cordova.dialogs" via plugin registry
          Installing org.apache.cordova.dialogs (android)
          Installing org.apache.cordova.dialogs (firefoxos)
          ReferenceError: xml_helpers is not defined
          at Object.module.exports.package_name (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/platforms/firefoxos.js:27:26)
          at PlatformMunger.generate_plugin_config_munge (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:285:54)
          at PlatformMunger.add_plugin_changes (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:211:29)
          at /var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:368:14
          at Array.forEach (native)
          at PlatformMunger_process [as process] (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:367:45)
          at Object.exports.process (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:77:12)
          at Object.handlePrepare (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/prepare.js:72:20)
          at /var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/install.js:413:33
          at _fulfilled (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/node_modules/q/q.js:798:54)

          Show
          Steckelfisch Gert-Jan Braas added a comment - - edited the log: braas@chickenrun:~/projects/ligplekkenonderweg/LPOWC$ cordova plugin add org.apache.cordova.dialogs Fetching plugin "org.apache.cordova.dialogs" via plugin registry Installing org.apache.cordova.dialogs (android) Installing org.apache.cordova.dialogs (firefoxos) ReferenceError: xml_helpers is not defined at Object.module.exports.package_name (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/platforms/firefoxos.js:27:26) at PlatformMunger.generate_plugin_config_munge (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:285:54) at PlatformMunger.add_plugin_changes (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:211:29) at /var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:368:14 at Array.forEach (native) at PlatformMunger_process [as process] (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:367:45) at Object.exports.process (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/util/config-changes.js:77:12) at Object.handlePrepare (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/prepare.js:72:20) at /var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/src/install.js:413:33 at _fulfilled (/var/tmp/braas/projects/cordova/cordova-github/cordova-plugman/node_modules/q/q.js:798:54)
          Show
          Steckelfisch Gert-Jan Braas added a comment - fix at: https://github.com/apache/cordova-plugman/pull/61
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 78e3650e9b483fa1e98bfe01458a00b76d422446 in cordova-plugman's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=78e3650 ]

          Merge branch 'CB-6160' of github.com:Steckelfisch/cordova-plugman

          Show
          jira-bot ASF subversion and git services added a comment - Commit 78e3650e9b483fa1e98bfe01458a00b76d422446 in cordova-plugman's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=78e3650 ] Merge branch ' CB-6160 ' of github.com:Steckelfisch/cordova-plugman
          Hide
          jsoref Josh Soref added a comment -

          Steve Gill: That merge is unfortunate.

          cordova create yip; cd yip; cordova platform add android ios blackberry10; node --debug-brk cordova plugin add org.cordova.mobile-spec-dependencies --searchpath ~/Cordova/cordova-mobile-spec; cordova plugin remove org.cordova.mobile-spec-dependencies; cordova plugin

          Failed to install 'org.cordova.mobile-spec-dependencies':TypeError: Arguments to path.join must be strings
          at path.js:360:15
          at Array.filter (native)
          at Object.exports.join (path.js:358:36)
          at cordova-plugman/src/install.js:338:39

          commit ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
          Author: Jonathan Bond
          + dep.subdir = path.join(dep.subdir.split('/'));
          ...

          • dep_subdir = path.join.apply(null, dep_subdir.split('/'));

          Broke this. I'm not sure what sort of testing people are doing. But I'm not a fan. At the very least the test which I'm showing above should pass for each and every change to plugman.

          Show
          jsoref Josh Soref added a comment - Steve Gill : That merge is unfortunate. cordova create yip; cd yip; cordova platform add android ios blackberry10; node --debug-brk cordova plugin add org.cordova.mobile-spec-dependencies --searchpath ~/Cordova/cordova-mobile-spec; cordova plugin remove org.cordova.mobile-spec-dependencies; cordova plugin Failed to install 'org.cordova.mobile-spec-dependencies':TypeError: Arguments to path.join must be strings at path.js:360:15 at Array.filter (native) at Object.exports.join (path.js:358:36) at cordova-plugman/src/install.js:338:39 commit ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9 Author: Jonathan Bond + dep.subdir = path.join(dep.subdir.split('/')); ... dep_subdir = path.join.apply(null, dep_subdir.split('/')); Broke this. I'm not sure what sort of testing people are doing. But I'm not a fan. At the very least the test which I'm showing above should pass for each and every change to plugman.
          Hide
          jsoref Josh Soref added a comment -

          Even with that, I get:

          Error: ENOENT, no such file or directory '.../Cordova/cordova-mobile-spec/plugin.xml'
          at Object.fs.openSync (fs.js:427:18)
          at Object.fs.readFileSync (fs.js:284:15)
          at Object.module.exports.parseElementtreeSync (cordova-plugman/src/util/xml-helpers.js:119:27)

          It should be looking for:
          .../Cordova/cordova-mobile-spec/dependencies-plugin/plugin.xml

          Show
          jsoref Josh Soref added a comment - Even with that, I get: Error: ENOENT, no such file or directory '.../Cordova/cordova-mobile-spec/plugin.xml' at Object.fs.openSync (fs.js:427:18) at Object.fs.readFileSync (fs.js:284:15) at Object.module.exports.parseElementtreeSync (cordova-plugman/src/util/xml-helpers.js:119:27) It should be looking for: .../Cordova/cordova-mobile-spec/dependencies-plugin/plugin.xml
          Hide
          Steckelfisch Gert-Jan Braas added a comment -

          It's tested on my CB-6160 branch on github with 'npm test'.
          I'm afraid I'm not aware of any other tests.

          how does a 2-line change in src/platforms/firefoxos.js affect anything in android, ios or blackberry10?

          if I look at
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=78e3650 ]
          it seems to me there is a lot more changed than just the alteration I made.

          Show
          Steckelfisch Gert-Jan Braas added a comment - It's tested on my CB-6160 branch on github with 'npm test'. I'm afraid I'm not aware of any other tests. how does a 2-line change in src/platforms/firefoxos.js affect anything in android, ios or blackberry10? if I look at [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=78e3650 ] it seems to me there is a lot more changed than just the alteration I made.
          Hide
          zalun Piotr Zalewa added a comment -

          Ping. What test should be run to test plugman?
          We need this shipped. I believe bug was introduced in 0.20.1 or 0.20.2
          I will try tomorrow, but I haven't been working on plugman yet

          Show
          zalun Piotr Zalewa added a comment - Ping. What test should be run to test plugman? We need this shipped. I believe bug was introduced in 0.20.1 or 0.20.2 I will try tomorrow, but I haven't been working on plugman yet
          Hide
          zalun Piotr Zalewa added a comment - - edited

          As far as I can see this merge is actually in master here: https://github.com/apache/cordova-plugman/blob/master/src/platforms/firefoxos.js#L4
          Can we please ship it?

          Show
          zalun Piotr Zalewa added a comment - - edited As far as I can see this merge is actually in master here: https://github.com/apache/cordova-plugman/blob/master/src/platforms/firefoxos.js#L4 Can we please ship it?
          Hide
          bartvanvelden Bart van Velden added a comment -

          issues seem similar

          Show
          bartvanvelden Bart van Velden added a comment - issues seem similar
          Hide
          Somatic Maxime LUCE added a comment -

          Is this issue still valid ? It seems fixed in :
          https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/firefoxos.js#L29.
          Can we resolve this issue ?

          Show
          Somatic Maxime LUCE added a comment - Is this issue still valid ? It seems fixed in : https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/firefoxos.js#L29 . Can we resolve this issue ?
          Hide
          Steckelfisch Gert-Jan Braas added a comment -

          Yes. I think that's OK.
          It was a blocker, and it seems to be fixed

          Show
          Steckelfisch Gert-Jan Braas added a comment - Yes. I think that's OK. It was a blocker, and it seems to be fixed
          Hide
          Somatic Maxime LUCE added a comment -

          This issues has already been fixed in new plugman releases

          Show
          Somatic Maxime LUCE added a comment - This issues has already been fixed in new plugman releases

            People

            • Assignee:
              Unassigned
              Reporter:
              Steckelfisch Gert-Jan Braas
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development