[CB-5984] WP8 add/remove dll resources is crufty

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.5.0
• Component/s: cordova-plugman, cordova-wp8 (DEPRECATED)

Environment

Windows

• Assignee: Jesse MacFadyen
• Reporter: Jesse MacFadyen
• Created: 06/Feb/14 23:55
• Updated: 23/Aug/18 07:29
• Resolved: 06/Mar/14 01:08

Description

plugman + wp8 has support for adding/removing dll resources to the project, although there are multiple potential issues with string comparison in filesnames.

Code like this:

var parts = relative_path.split('\\');
var dll_name = parts[parts.length - 1].substr(0, parts[parts.length - 1].length - 4);

Can easily be replaced with this :

var dll_name = path.basename(relative_path, '.dll');

I fear there are also latent bugs here, so more tests should also be added.

Issue Links

• is related to: CB-5993 Add/Remove binary (.dll) assets
• relates to: CB-5970 plugman should be able to install a dependent project