[CB-5770] cordova define statement that wraps plugin JS files potentially is commented out unintentionally

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.0, 3.2.0, 3.3.0
• Component/s: cordova-plugman
• Labels: plugin plugins

Environment

Mac OSX v10.8.5

• Assignee: Andrew Grieve
• Reporter: Josh Bavari
• Created: 10/Jan/14 21:00
• Updated: 23/Aug/18 07:27
• Resolved: 11/Jan/14 01:12

Description

When adding plugins with plugman, the process wraps the containing javascript content with the following:

cordova.define("moduleName", function(require, exports, module)

{ scriptContent }); If a plugin JS file has a comment at the end of the file that plugman is wrapping with a cordova.define statement, the string that is concatenated at the end, "}

);", may be commented out.

For example, given the original plugin file before preparing:

var module =

{ .. code .. };
//Some comment comes here

The file after preparing:

cordova.define("moduleName", function(require, exports, module) {
var module = { .. code .. }

;
//Some comment comes here });

The fix is to add a new line before placing the end bracket and parenthesis.