[CB-560] Cordova breaking iOS plugins

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.1
• Fix Version/s: 1.7.0
• Component/s: cordova-js

Environment

From https://groups.google.com/forum/?fromgroups#!topic/phonegap/2G5OPKV_FdQ someone apparently tried upgrading from PhoneGap 1.1 to 1.6.

• Assignee: Filip Maj
• Reporter: chbrody
• Created: 24/Apr/12 05:25
• Updated: 01/Sep/14 18:33
• Resolved: 30/Apr/12 23:42

Description

From 1.4 to 1.5, the namespace was changed from PhoneGap to Cordova which was breaking all of the existing plugins. I eventually provided a shim class but it was too late to stop the pain. Then in Javascript only Cordova was changed to cordova, breaking the iOS plugins yet again. I noticed in cordova (1.6.0) JS:

if (!window.PhoneGap) {
window.PhoneGap = cordova;
}

This should have been done for Cordova like:
if (!Cordova) {
Cordova = cordova;
}

Yes we should be deprecating the old namespaces for removal in another major release. Any API changes made before a major release should be made with a workaround, to be deprecated, and tested with some plugins before shipping.