[CB-5468] improve config.xml encoding handling of utf-8

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5.0
• Component/s: cordova-blackberry (DEPRECATED), cordova-cli, cordova-plugman
• Assignee: Josh Soref
• Reporter: Josh Soref
• Created: 22/Nov/13 20:02
• Updated: 23/Aug/18 07:19
• Resolved: 15/Apr/14 19:00

Description

If you have a config.xml w/o a BOM in UTF-8 and try to use cordova build on BlackBerry, you'll get an error.

That logic is here:
https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/templates/project/cordova/lib/packager-utils.js#L143

cordova cli on the other hand seems to only handle UTF-8 (and not UCS2/UTF-16).

That logic is here:
https://github.com/apache/cordova-cli/blob/master/src/xml-helpers.js#L111

The specification for config.xml is here:
http://www.w3.org/TR/widgets/#algorithm-to-process-a-configuration-document
Let doc be the result of loading the widget config doc as a [DOMCore] Document using an [XML] parser that is both [XMLNS]-aware and xml:lang aware.

[XML] defers to:
http://www.w3.org/TR/2008/REC-xml-20081126/#charsets

which says:
The mechanism for encoding character code points into bit patterns may vary from entity to entity. All XML processors must accept the UTF-8 and UTF-16 encodings of Unicode [Unicode].