[CB-5192] Plugman engine check fails on Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-plugman

Environment

Windows

• Assignee: Braden Shepherdson
• Reporter: Sergey Grebnov
• Created: 24/Oct/13 06:10
• Updated: 23/Aug/18 07:28
• Resolved: 24/Oct/13 17:41

Description

Right now the simplest (and also the most correct IMO) way to specify plugin restrictions to specific cordova version is the following:

plugin.xml:

<engines>
<engine name="cordova" version=">=2.7.0" />
</engines>

But in this case as per plugman current implementation and engines definition(plugman/src/util/default-engines.js) plugman won't be able to resove script because on Windows the script named 'version.bat', not just 'version'.

module.exports = function(project_dir){
return {
'cordova':

{ 'platform':'*', 'scriptSrc': path.join(project_dir,'cordova','version') }

, <- works in general, but NOT for WP7/8
...
'cordova-wp8':

{ 'platform':'wp8', 'scriptSrc': path.join(project_dir,'cordova','version.bat') }

, <- correct location, not used in case of example above

child_process.exec should correctly resolve this case (missing cmd file extension) but plugman check for file location so it fails to find it.

This should affect all platforms which are supported on Windows and use .bat files (WP7/8, BlackBerry, Android)