Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-5191

Deprecate <url-filter>

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.2.0
    • cordova-android
    • None

    Description

      For the onOverrideUrlLoading() function to be called on a plugin, it must have a <url-filter> in it's <feature> tag.

      This is an undocumented quirk, and I don't think it has any benefit. In order not to break existing plugins that rely on it though, I'm going to:

      1. If a plugin does have a url-filter, show a deprecation message and still apply the filtering before calling its onOverrideUrlLoading() function.
      2. If a plugin does not have a url-filter, then always call its onOverrideUrlLoading() function.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            agrieve Andrew Grieve
            agrieve Andrew Grieve
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment