[CB-5105] remove dead code for device.version from native plugin source

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.0
• Component/s: cordova-plugin-device
• Assignee: Martin Gonzalez
• Reporter: Marcel Kinard
• Created: 16/Oct/13 19:11
• Updated: 24/May/19 21:30
• Resolved: 03/Mar/14 19:13

Description

The solution for CB-5085 (and related) is for device.js to set device.cordova using CORDOVA_JS_BUILD_LABEL from cordova.js, instead of having native code do that (usually with hardcoded values) and return it back from exec(). So once CB-5085 is fixed in this way, then any native code that computes device.version is dead. That dead code should be removed from cordova-plugin-device, if for no other reason than reducing confusion.

The following platforms are affected: Android, BB10, WP8, Win8.

iOS is doing something special, but doing it right, so don't make any changes to iOS.

Issue Links

• depends upon: CB-5085 device.cordova on Android 3.1.x returns "dev"
• depends upon: CB-5086 device.cordova on BB10 3.1.x returns "dev"
• depends upon: CB-5087 device.cordova on Win8 3.1.x returns "0.0.0"
• depends upon: CB-5088 device.cordova on WP8 3.1.x returns "3.0.0"
• is related to: CB-5121 deprecate device.cordova in favor of cordova.version