Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-4995

iOS application crashes when InAppBrowser is opened and quickly closed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0, 2.8.0, 2.9.0, 3.0.0
    • Fix Version/s: 3.2.0
    • Labels:
      None
    • Environment:

      iOS

      Description

      I personally experienced the issue with 2.8.15, but it appears others are seeing the same problem even on version 3. Just now, I quickly took a look at the latest version 3 source code, and it is likely that the issue is still around. That is, I had identified the cause of the crash and we fixed it in our app.

      The issue is presented when a user rapidly opens and closes InAppBrowser while using Cordova iOS application because (referring to the latest CDVInAppBrowser.m as of 10/3/2013 with commit hash of a001cffc30cf94cb406128f7b68d143e2cd62114) self.inAppBrowserViewController (line: 332) is nil if 'browserExit' (line: 353) is called before 'webViewDidFinishLoad' (line: 328) is invoked.

      We put our own patch around line 332 as below, and didn't experience the crash any more with 2.8.15

      if (self.inAppBrowserViewController != nil) {
          url = [self.inAppBrowserViewController.currentURL absoluteString];  
      } else {
          url = @"";
      }
      

        Attachments

          Activity

            People

            • Assignee:
              agrieve Andrew Grieve
              Reporter:
              hyong Hyong Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: