[CB-4917] FB - FileUtils.java - may fail to clean up streams

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: 2.9.0
• Component/s: cordova-android, cordova-plugin-file
• Assignee: Ian Clelland
• Reporter: Peter
• Created: 26/Sep/13 02:32
• Updated: 23/Aug/18 07:10
• Resolved: 14/Oct/15 16:51

Description

Resolve FindBugs issues in FileUtils.java

In copyAction method

Before

FileInputStream istream = new FileInputStream(srcFile);
FileOutputStream ostream = new FileOutputStream(destFile);
FileChannel input = istream.getChannel();
FileChannel output = ostream.getChannel();

try {
    input.transferTo(0, input.size(), output);
} finally {
    istream.close();
    ostream.close();
    input.close();
    output.close();
}

After

FileInputStream istream = new FileInputStream(srcFile);
try {
    FileOutputStream ostream = new FileOutputStream(destFile);
    FileChannel input = istream.getChannel();
    FileChannel output = ostream.getChannel();		
    try {
        input.transferTo(0, input.size(), output);
    } finally {
        ostream.close();
        input.close();
        output.close();
    }
} finally {
    istream.close();
}

In write method

Before

ByteArrayInputStream in = new ByteArrayInputStream(rawData);
FileOutputStream out = new FileOutputStream(filename, append);
byte buff[] = new byte[rawData.length];
in.read(buff, 0, buff.length);
out.write(buff, 0, rawData.length);
out.flush();
out.close();

After

ByteArrayInputStream in = new ByteArrayInputStream(rawData);
FileOutputStream out = new FileOutputStream(filename, append);
try {
    byte buff[] = new byte[rawData.length];
    in.read(buff, 0, buff.length);
    out.write(buff, 0, rawData.length);
    out.flush();
} finally {
    out.close();
}

Issue Links

• Is contained by: CB-4909 Resolve FindBugs issues