[CB-4907] FB - FileTransfer.java - method does not close stream

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.9.0
• Component/s: cordova-android, cordova-plugin-file-transfer (DEPRECATED)
• Assignee: Bas Bosman
• Reporter: Peter
• Created: 25/Sep/13 01:22
• Updated: 23/Aug/18 07:28
• Resolved: 10/Feb/14 18:27

Description

Resolve FindBugs reported issue in FileTransfer.java:

Before

String line = reader.readLine();
while(line != null)
{
    bodyBuilder.append(line);
    line = reader.readLine();
    if(line != null)
        bodyBuilder.append('\n');
}
body = bodyBuilder.toString();

After

try {
    String line = reader.readLine();
    while(line != null) {
        bodyBuilder.append(line);
        line = reader.readLine();
        if(line != null) {
            bodyBuilder.append('\n');
        }
    }
    body = bodyBuilder.toString();
} finally {
    reader.close();
}

Issue Links

• Is contained by: CB-4909 Resolve FindBugs issues