[CB-4906] FB - Capture.java - method does not clean up stream

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Abandoned
• Affects Version/s: 2.9.0
• Component/s: cordova-plugin-media-capture
• Labels: Android
• Assignee: Unassigned
• Reporter: Peter
• Created: 25/Sep/13 01:19
• Updated: 23/Aug/18 06:50
• Resolved: 14/Oct/16 22:28

Description

Resolve FindBugs reported issue in Capture.java:

Before

FileInputStream fis = new FileInputStream(DirectoryManager.getTempDirectoryPath(this.cordova.getActivity()) + "/Capture.jpg");                    
OutputStream os = this.cordova.getActivity().getContentResolver().openOutputStream(uri);
byte[] buffer = new byte[4096];
int len;
while ((len = fis.read(buffer)) != -1) {
    os.write(buffer, 0, len);
}
os.flush();
os.close();
fis.close();

After

FileInputStream fis = new FileInputStream(DirectoryManager.getTempDirectoryPath(this.cordova.getActivity()) + "/Capture.jpg");
try {
    OutputStream os = this.cordova.getActivity().getContentResolver().openOutputStream(uri);
    try {
        byte[] buffer = new byte[4096];
        int len;
        while ((len = fis.read(buffer)) != -1) {
            os.write(buffer, 0, len);
        }
        os.flush();
    } finally {
        os.close();
    }
} finally {
    fis.close();
}

Issue Links

• Is contained by: CB-4909 Resolve FindBugs issues