Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-4811

Device plugin requires no permissions, so remove from documentaion

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: cordova-plugin-device
    • Labels:
      None
    • Environment:

      Windows 7

      Description

      The docs for the cordova-plugin-device plugin (http://cordova.apache.org/docs/en/edge/cordova_device_device.md.html#Device) say that the plugin will add
      <uses-permission android:name="android.permission.READ_PHONE_STATE" />
      to AndroidManifest.xml

      However, it seems like this is not actually the case, because 1) there is nothing in the plugin.xml file that would do this (missing <config-file target="AndroidManifest.xml" parent="/*">[...]) element, and 2) it doesn't seem like the device functionality needs this permission at all.

      Unless there are some strange dependencies that I'm not seeing between other plugins that require the device plugin to have this permission (that wouldn't make sense...?), I think the docs should be edited to reflect this to avoid causing confusion (it confused me at least!)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mwbrooks Michael William Brooks
                Reporter:
                mrbillau Michael Billau
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: