[CB-4602] getPreferredLanguage platform inconsistencies

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.6.0, 3.0.0
• Component/s: cordova-android, cordova-plugin-globalization (DEPRECATED)

Environment

Android

• Assignee: Michael Billau
• Reporter: Jon Whitlock
• Created: 16/Aug/13 13:36
• Updated: 23/Aug/18 07:19
• Resolved: 16/Jul/14 13:38

Description

In;
https://github.com/apache/cordova-docs/blob/master/docs/en/edge/cordova/globalization/globalization.getPreferredLanguage.md

"Returns the language identifier string to the successCallback with a properties object as a parameter. That object should have a value property with a String value."

navigator.globalization.getPreferredLanguage(
function (language)

{alert('language: ' + language.value + '\n');}

,
function ()

{alert('Error getting language\n');}

);

On Android the function doesn't seem to return an identifier as such, it returns a string describing the language localised to that language, e.g. "English" for English or "中文" for Japanese. Naturally this is less than ideal for subsequent string operations, furthermore on that page "Windows Phone 8 Quirks - Returns the ISO 639-1 two-letter code for the current language" which is an identifier, and also what I would expect (or an ISO 639-2 code, as per http://www.loc.gov/standards/iso639-2/php/code_list.php)

Android seems to support 639-2 http://developer.android.com/reference/java/util/Locale.html#getISO3Language()

I have no idea what it returns on other platforms, but to keep client code consistent I guess it would good if this could be normalised in the API.

Have tested this on v3.0 and 2.6, is the same.

As an aside, the locale is not really what I want here, as the user may be in the US but have Japanese as their preferred language.

Thanks,
jon

(first go at using Jira, apols if I got something wrong!)

Issue Links

• incorporates: CB-7064 Added tests to Globalization covering changes from CB-4602

Sub-Tasks

• Added tests to Globalization covering changes from CB-4602: Closed