Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.6.0
    • Labels:
      None

      Description

      One common use-case for the InAppBrowser is to handle an OAuth flow. Some flows can be done without any user interaction, so it would be great if the InAppBrowser had an option where it would start hidden, and could later be reveals through a JS call.

      E.g.

      var iab = window.open('$OAUTH_URL', 'hidden=yes');
      //some time later.
      iab.show();

        Activity

        Hide
        shazron Shazron Abdullah added a comment -

        Two parts to this in native:
        1. handle 'hidden' window option (boolean)
        2. implement 'show' function

        Show
        shazron Shazron Abdullah added a comment - Two parts to this in native: 1. handle 'hidden' window option (boolean) 2. implement 'show' function
        Hide
        purplecabbage Jesse MacFadyen added a comment -

        Should the visibility api actually be :

        var iab = window.open('$OAUTH_URL', 'hidden=yes');

        //some time later.
        iab.focus();

        // some time later than that
        iab.blur();

        Show
        purplecabbage Jesse MacFadyen added a comment - Should the visibility api actually be : var iab = window.open('$OAUTH_URL', 'hidden=yes'); //some time later. iab.focus(); // some time later than that iab.blur();
        Hide
        drkemp David Kemp added a comment -

        It seems like focus() and blur() typically mean things like z-ordering and entry.

        I would like to move forward with this item using the syntax:

        var iab = window.open('$OAUTH_URL', 'hidden=yes');
        //some time later.
        iab.show();
        // some time later than that
        iab.hide();

        with the added note that since there is no open requests for hide(), it be left for later.

        Show
        drkemp David Kemp added a comment - It seems like focus() and blur() typically mean things like z-ordering and entry. I would like to move forward with this item using the syntax: var iab = window.open('$OAUTH_URL', 'hidden=yes'); //some time later. iab.show(); // some time later than that iab.hide(); with the added note that since there is no open requests for hide(), it be left for later.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dcbd189803681d61d261f4a5f76cd89a41b605ae in branch refs/heads/master from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=dcbd189 ]

        CB-3420: add hidden option to InAppBrowser

        Show
        jira-bot ASF subversion and git services added a comment - Commit dcbd189803681d61d261f4a5f76cd89a41b605ae in branch refs/heads/master from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=dcbd189 ] CB-3420 : add hidden option to InAppBrowser
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 100b954da984f421ee48a41bdddf32af928a5b34 in branch refs/heads/master from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=100b954 ]

        CB-3420: add hidden option to InAppBrowser

        Show
        jira-bot ASF subversion and git services added a comment - Commit 100b954da984f421ee48a41bdddf32af928a5b34 in branch refs/heads/master from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=100b954 ] CB-3420 : add hidden option to InAppBrowser
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c3b8b279b091c4394dcf297566cfe453f58a1f82 in branch refs/heads/master from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=c3b8b27 ]

        CB-3420: add hidden option to InAppBrowser

        Show
        jira-bot ASF subversion and git services added a comment - Commit c3b8b279b091c4394dcf297566cfe453f58a1f82 in branch refs/heads/master from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=c3b8b27 ] CB-3420 : add hidden option to InAppBrowser
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fde980a492ae96ff11ccb77ad8b9aae3bed55322 in branch refs/heads/master from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=fde980a ]

        CB-3420: add hidden option to InAppBrowser

        Show
        jira-bot ASF subversion and git services added a comment - Commit fde980a492ae96ff11ccb77ad8b9aae3bed55322 in branch refs/heads/master from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=fde980a ] CB-3420 : add hidden option to InAppBrowser
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 421aff89471477f96d068b55e96be4960de19674 in branch refs/heads/master from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=421aff8 ]

        CB-3420: add hidden option to InAppBrowser

        Show
        jira-bot ASF subversion and git services added a comment - Commit 421aff89471477f96d068b55e96be4960de19674 in branch refs/heads/master from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=421aff8 ] CB-3420 : add hidden option to InAppBrowser
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 421aff89471477f96d068b55e96be4960de19674 in branch refs/heads/3.0.0 from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=421aff8 ]

        CB-3420: add hidden option to InAppBrowser

        Show
        jira-bot ASF subversion and git services added a comment - Commit 421aff89471477f96d068b55e96be4960de19674 in branch refs/heads/3.0.0 from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=421aff8 ] CB-3420 : add hidden option to InAppBrowser
        Hide
        purplecabbage Jesse MacFadyen added a comment -

        How did this move forward without consensus? We essentially have a bug now that iOS is different than the other platforms.

        Show
        purplecabbage Jesse MacFadyen added a comment - How did this move forward without consensus? We essentially have a bug now that iOS is different than the other platforms.
        Hide
        shazron Shazron Abdullah added a comment -

        It's implemented in Android too. We already had this discussion in the ML that "feature parity" / waiting for all platforms shouldn't prevent us from implementing it for the core platforms. I'll try to dig up the link to that discussion.

        Show
        shazron Shazron Abdullah added a comment - It's implemented in Android too. We already had this discussion in the ML that "feature parity" / waiting for all platforms shouldn't prevent us from implementing it for the core platforms. I'll try to dig up the link to that discussion.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d9c639f076bf126acbf8f3e537c8211a39ebdc7d in branch refs/heads/master from David Kemp
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=d9c639f ]

        CB-3420 added hidden option and show method
        Also minor doc cleanup

        Show
        jira-bot ASF subversion and git services added a comment - Commit d9c639f076bf126acbf8f3e537c8211a39ebdc7d in branch refs/heads/master from David Kemp [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=d9c639f ] CB-3420 added hidden option and show method Also minor doc cleanup
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9768ec2ef0154aeba71a7de68b5e57feffc00836 in branch refs/heads/dev from Jesse MacFadyen
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=9768ec2 ]

        CB-3420 WP feature hidden=yes implemented

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9768ec2ef0154aeba71a7de68b5e57feffc00836 in branch refs/heads/dev from Jesse MacFadyen [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=9768ec2 ] CB-3420 WP feature hidden=yes implemented

          People

          • Assignee:
            drkemp David Kemp
            Reporter:
            agrieve Andrew Grieve
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development