[CB-2845] CompassError, PositionError constants not attached to prototype as specified in W3C document

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0, 2.6.0
• Component/s: cordova-plugin-device-orientation (DEPRECATED), cordova-plugin-geolocation
• Labels: audit triaged

Environment

Any

• Assignee: Unassigned
• Reporter: Thomas K.
• Created: 29/Mar/13 13:44
• Updated: 23/Aug/18 06:57
• Resolved: 05/Jan/16 06:14

Description

CompassError.js PositionError.js do not define the error constants on the prototype of the object. Hence the constants are not passed into the error function as specified in the W3C document http://dev.w3.org/geo/api/spec-source.html#position_error_interface (see: interface PositionError { const unsigned short PERMISSION_DENIED = 1; ...)

Fix: define in the library PositionError.js and Compass.js constants additionally like this:
PositionError.prototype.PERMISSION_DENIED = 1;

https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/PositionError.js#L34
https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/CompassError.js#L31

W3C compatible code is:
positionError = function(gpsError)
{
switch(gpsError.code)
{
case gpsError.PERMISSION_DENIED:
errorMessage = "Access to GPS denied!";
break;
...

Issue Links

• duplicates: CB-4610 locationerror event does not contain the three constants (TIMEOUT, PERMISSION_DENIED, POSITION_UNAVAILABLE)
• incorporates: CB-10285 PositionError should contain error code constants