[CB-2421] On Windows 8 , FileTransfer.upload returns wrong FileUploadResult

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: cordova-plugin-file-transfer (DEPRECATED), cordova-windows
• Assignee: Jesse MacFadyen
• Reporter: Youval Bronicki
• Created: 12/Feb/13 22:50
• Updated: 23/Aug/18 06:58
• Resolved: 28/Jan/14 23:30

Description

When reporting success, the existing code attempts to read the original file as a string and report it as a response (instead of the server's response).
It also calls a non-existent constructor new FileUploadResult(basicProperties.size, code, fileContent).

When the uploaded file is not textual (e.g. a JPEG image), the current code fails altogether because dataReader.readString throws an exception.

Here is a possible correction:

Old Code:
storageFile.getBasicPropertiesAsync().done(function (basicProperties) {
Windows.Storage.FileIO.readBufferAsync(storageFile).done(function (buffer)

{ var dataReader = Windows.Storage.Streams.DataReader.fromBuffer(buffer); var fileContent = dataReader.readString(buffer.length); dataReader.close(); win(new FileUploadResult(basicProperties.size, code, fileContent)); }

);
}, function () {
error(FileTransferError.INVALID_URL_ERR);
});

Correction:
storageFile.getBasicPropertiesAsync().done(function (basicProperties) {
var res = new FileUploadResult();
res.bytesSent=basicProperties.size;
res.responseCode=response.status;
res.response=response.responseText;
win(res);
});

Possible a more elegant correction would be to add the missing constructor for FileUploadResult