Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-2063

InAppBrowser - support iPad presentation style, iOS transition styles

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • iOS

    Description

      http://developer.apple.com/library/ios/#featuredarticles/ViewControllerPGforiPhoneOS/ModalViewControllers/ModalViewControllers.html

      Through the _options_ parameter to window.open:

      • presentationstyle=fullscreen (default)
      • presentationstyle=pagesheet
      • presentationstyle=formsheet
      • transitionstyle=coververtical (default)
      • transitionstyle=fliphorizontal
      • transitionstyle=crossdissolve

      Attachments

        Issue Links

          Activity

            iroh Chris Wells made changes -
            Workflow Classic - editable closed [ 14069134 ] classic default workflow [ 14080975 ]
            iroh Chris Wells made changes -
            Workflow classic default workflow [ 12742449 ] Classic - editable closed [ 14069134 ]
            jcesarmobile jcesarmobile made changes -
            Fix Version/s 2.4.0 [ 12323473 ]
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Closed [ 6 ]
            jcesarmobile jcesarmobile added a comment -

            Fixed in 1.4.1-dev

            jcesarmobile jcesarmobile added a comment - Fixed in 1.4.1-dev
            githubbot ASF GitHub Bot added a comment -

            Github user cordova-qa commented on the issue:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/176

            Cordova CI Build has completed successfully.

            *Commit* - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/176/commits/21fcc276c1bd5aa4cf8da4e8187667ff21bc0bc9)
            *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54/)

            Builder Name Console Output Test Report Device Logs
            :---: :---: :---: :---:
            [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/artifact/)
            [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/artifact/)
            [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/artifact/)
            [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/artifact/)
            [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/artifact/)
            githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/176 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-inappbrowser/pull/176/commits/21fcc276c1bd5aa4cf8da4e8187667ff21bc0bc9 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/54//PLATFORM=android/artifact/ )
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #176 (Web Link)" [ 50826 ] This issue links to "GitHub Pull Request #176 (Web Link)" [ 50826 ]
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/176

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/176
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #176 (Web Link)" [ 50826 ] This issue links to "GitHub Pull Request #176 (Web Link)" [ 50826 ]

            Commit e9734667c6a4e917848dac594369e5c9dd3180b8 in cordova-plugin-inappbrowser's branch refs/heads/master from jcesarmobile
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=e973466 ]

            CB-2063: (ios) Fixed presentation style

            This closes #176

            jira-bot ASF subversion and git services added a comment - Commit e9734667c6a4e917848dac594369e5c9dd3180b8 in cordova-plugin-inappbrowser's branch refs/heads/master from jcesarmobile [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=e973466 ] CB-2063 : (ios) Fixed presentation style This closes #176
            githubbot ASF GitHub Bot added a comment -

            GitHub user jcesarmobile opened a pull request:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/176

            CB-2063: (ios) Fixed presentation style

                1. Platforms affected
                  iOS
                1. What does this PR do?
                  Presentation style stopped working and this PR fix it
                1. What testing has been done on this change?
                  Tested on iPad
                1. Checklist

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-2063-fix-transition-style

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/176.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #176


            commit 21fcc276c1bd5aa4cf8da4e8187667ff21bc0bc9
            Author: Julio CĂ©sar <jcesarmobile@gmail.com>
            Date: 2016-07-17T18:26:30Z

            CB-2063: (ios) Fixed presentation style


            githubbot ASF GitHub Bot added a comment - GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/176 CB-2063 : (ios) Fixed presentation style Platforms affected iOS What does this PR do? Presentation style stopped working and this PR fix it What testing has been done on this change? Tested on iPad Checklist [X] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-2063 -fix-transition-style Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/176.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #176 commit 21fcc276c1bd5aa4cf8da4e8187667ff21bc0bc9 Author: Julio CĂ©sar <jcesarmobile@gmail.com> Date: 2016-07-17T18:26:30Z CB-2063 : (ios) Fixed presentation style
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #176 (Web Link)" [ 50826 ]
            jcesarmobile jcesarmobile made changes -
            Assignee jcesarmobile [ jcesarmobile ]
            jcesarmobile jcesarmobile made changes -
            Link This issue is cloned by CB-7997 [ CB-7997 ]
            shazron Shazron Abdullah made changes -
            Assignee Shazron Abdullah [ shazron ]
            shazron Shazron Abdullah made changes -
            Component/s Plugin InAppBrowser [ 12320641 ]
            Component/s iOS [ 12316400 ]
            Environment iOS
            shazron Shazron Abdullah made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            iuriik Iurii Kyian added a comment -

            As for the current production version 0.5.3 the problem is not solved for iPad.
            The simple solution will be to add in the file CDVInAppBrowser.m the copy of modalPresentationStyle into 'nav' controller in method

            • (void)show:(CDVInvokedUrlCommand*)command

            It will look like this:

            CDVInAppBrowserNavigationController* nav = [[CDVInAppBrowserNavigationController alloc]
            initWithRootViewController:self.inAppBrowserViewController];
            nav.modalPresentationStyle = self.inAppBrowserViewController.modalPresentationStyle;

            iuriik Iurii Kyian added a comment - As for the current production version 0.5.3 the problem is not solved for iPad. The simple solution will be to add in the file CDVInAppBrowser.m the copy of modalPresentationStyle into 'nav' controller in method (void)show:(CDVInvokedUrlCommand*)command It will look like this: CDVInAppBrowserNavigationController* nav = [ [CDVInAppBrowserNavigationController alloc] initWithRootViewController:self.inAppBrowserViewController]; nav.modalPresentationStyle = self.inAppBrowserViewController.modalPresentationStyle;
            shazron Shazron Abdullah made changes -
            Link This issue relates to CB-2311 [ CB-2311 ]
            shazron Shazron Abdullah made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            shazron Shazron Abdullah added a comment - Fix commit - http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/66945320
            shazron Shazron Abdullah made changes -
            Link This issue is duplicated by CB-1937 [ CB-1937 ]

            Note that pagesheet is really only for landscape mode.

            shazron Shazron Abdullah added a comment - Note that pagesheet is really only for landscape mode.
            shazron Shazron Abdullah added a comment - Pull request sent https://github.com/apache/cordova-ios/pull/3
            shazron Shazron Abdullah made changes -
            Summary InAppBrowser - support iPad presentation, transition styles InAppBrowser - support iPad presentation style, iOS transition styles
            shazron Shazron Abdullah made changes -
            Field Original Value New Value
            Description http://developer.apple.com/library/ios/#featuredarticles/ViewControllerPGforiPhoneOS/ModalViewControllers/ModalViewControllers.html

            Through the __options__ parameter to window.open:
            * presentationstyle=fullscreen (default)
            * presentationstyle=pagesheet
            * presentationstyle=formsheet
            http://developer.apple.com/library/ios/#featuredarticles/ViewControllerPGforiPhoneOS/ModalViewControllers/ModalViewControllers.html

            Through the __options__ parameter to window.open:
            * presentationstyle=fullscreen (default)
            * presentationstyle=pagesheet
            * presentationstyle=formsheet
            * transitionstyle=coververtical (default)
            * transitionstyle=fliphorizontal
            * transitionstyle=crossdissolve
            Summary InAppBrowser - support iPad presentation styles InAppBrowser - support iPad presentation, transition styles
            shazron Shazron Abdullah created issue -

            People

              jcesarmobile jcesarmobile
              shazron Shazron Abdullah
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: