Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0
    • Fix Version/s: Master
    • Component/s: Plugin Media
    • Labels:
    • Environment:

      All

      Description

      In the media API, different functions use different time units. For example:

      • media.getCurrentPosition returns the position in seconds.
      • media.seekTo sets the position in milliseconds

        Activity

        Per Quested Aronsson created issue -
        Per Quested Aronsson made changes -
        Field Original Value New Value
        Description In the media API, different functions use different time units. For example:
            *media.getCurrentPosition* returns the position in *seconds*.
            *media.seekTo* sets the position in *milliseconds*

        In the media API, different functions use different time units. For example:
        * *media.getCurrentPosition* returns the position in *seconds*.
        * *media.seekTo* sets the position in *milliseconds*

        Hide
        Shazron Abdullah added a comment -

        This would be a breaking API change if implemented. I agree it should be consistent but I don't know if it's worth it.

        Show
        Shazron Abdullah added a comment - This would be a breaking API change if implemented. I agree it should be consistent but I don't know if it's worth it.
        Hide
        Andrew Grieve added a comment -

        Agree. Let's leave this for whenever we do an API sweep. Added this to http://wiki.apache.org/cordova/Core%20API%20Audit#preview

        Show
        Andrew Grieve added a comment - Agree. Let's leave this for whenever we do an API sweep. Added this to http://wiki.apache.org/cordova/Core%20API%20Audit#preview
        Hide
        Simon MacDonald added a comment -

        The Media API needs to be killed with fire anyway. We should look at implementing the Audio tag JS interface as it is more along the lines of the regular monkey patching we do, IMHO.

        Show
        Simon MacDonald added a comment - The Media API needs to be killed with fire anyway. We should look at implementing the Audio tag JS interface as it is more along the lines of the regular monkey patching we do, IMHO.
        Hide
        Filip Maj added a comment -

        Assigned to media plugin, tagged as audit.

        Show
        Filip Maj added a comment - Assigned to media plugin, tagged as audit.
        Filip Maj made changes -
        Labels javascript audit javascript
        Assignee Filip Maj [ filmaj ] Steve Gill [ stevegill ]
        Component/s Plugin Media [ 12320647 ]
        Component/s CordovaJS [ 12317202 ]
        Steve Gill made changes -
        Assignee Steve Gill [ stevegill ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Per Quested Aronsson
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development