[CB-14048] Inappbrowser allowedSchemes doesn't check empty string

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: cordova-plugin-inappbrowser
• Assignee: Unassigned
• Reporter: Reed Richards
• Created: 22/Apr/18 18:10
• Updated: 23/Aug/18 07:56
• Resolved: 19/May/18 11:51

Description

The new AllowSchemes introduced with inappbrowser@3.0.0 doesn't check if  AllowSchemes contains  empty string after having being loaded, respectively only if null, which could lead to error in case a custom scheme is use but not set as white listed schema 

What I mean is that, if no preference would be set in config.xml but a custom scheme would be used (my case) then the variable allowSchemes won't be null but will contains an empty string

 

In InAppBrowser.java

 

else if (!url.startsWith("http:") && !url.startsWith("https:") && url.matches("^[a-z]*://.*?$")) {
    if (allowedSchemes == null) {
        String allowed = preferences.getString("AllowedSchemes", "");
        allowedSchemes = allowed.split(",");
    }
    if (allowedSchemes != null) { // <------- If  preference AllowedSchemes is not specified, variable allowedSchemes not gonna be null but an array containing an empty string
       for (String scheme : allowedSchemes) { 
           if (url.startsWith(scheme)) { 
              if (url.startsWith(scheme)) { // <------ which leads to the problem "urlidontwanttowhilelist://".startsWith("") == true

  

I would like to improve this check for example like following

 

if (url.startsWith(scheme) && !"".equals(scheme)) {

 

 Thx in advance for the improvement

 

Issue Links

• links to: GitHub Pull Request #268