Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-1387

Splash screens broken due to error in iPad detection code

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.0
    • 2.1.0
    • cordova-ios
    • None

    Description

      The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.

      The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mmocny Michal Mocny
            tqc Tom Clarkson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment