[CB-13825] Outdated node_modules

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0
• Fix Version/s: 4.1.0
• Component/s: cordova-osx
• Assignee: Tobias Bocanegra
• Reporter: Alberto Lalama
• Created: 24/Jan/18 00:36
• Updated: 23/Aug/18 07:50
• Resolved: 30/Jan/18 08:30

Description

Commit  f7db769af updated cordova-common to v2.1.0 without updating node_modules. This means that pinning cordova-osx to the github repo in config.xml fails to install plugins with the following error:

Installing "cordova-plugin-whitelist" for osx
Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property 'get' of undefined
at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
at handleInstall (cordova-lib/src/plugman/install.js:611:6)
at node_modules/cordova-lib/src/plugman/install.js:407:28
at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
at self.promiseDispatch.done (node_modules/cordova-lib/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch (node_modules/cordova-lib/node_modules/q/q.js:749:13)
at node_modules/cordova-lib/node_modules/q/q.js:509:49
at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You might need to try adding it again. Error: TypeError: Cannot read property 'get' of undefined

 

A straightforward solution would be to update node_modules (cordova-ios seems to do this regularly). Could we use a dependency manager (e.g. yarn)? Any other suggestions?

 

Issue Links

• links to: GitHub Pull Request #46