Details

      Description

      With autosaving now in place, we don't need `cordova platform save` anymore.

      By removing this command, we can also remove cordovaProject/platforms/platforms.json & cordova-lib/src/cordova/platform_metadata.js

      Deprecation notice will be added to cordova platform save until save command is removed in cordova@8

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-lib/pull/585

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/585
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5d9e3336071d00fc550cb1b042172466a0a86704 in cordova-lib's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=5d9e333 ]

          CB-13057 : added deprecation warning for cordova platform save

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5d9e3336071d00fc550cb1b042172466a0a86704 in cordova-lib's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=5d9e333 ] CB-13057 : added deprecation warning for cordova platform save
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user audreyso commented on the issue:

          https://github.com/apache/cordova-lib/pull/586

          Can I delete:
          1. commented out tests or parts of tests that contain platforms.json or platform_metadata?
          2. Can I delete save.js and save.spec.js?

          Show
          githubbot ASF GitHub Bot added a comment - Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/586 Can I delete: 1. commented out tests or parts of tests that contain platforms.json or platform_metadata? 2. Can I delete save.js and save.spec.js?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user audreyso opened a pull request:

          https://github.com/apache/cordova-lib/pull/586

          CB-13057 : Remove cordova platform save command

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?

          Remove cordova platform save command

              1. What testing has been done on this change?
              1. Checklist
          • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [X] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/audreyso/cordova-lib CB-13057-2

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/586.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #586


          commit 3f66326f751de7c78f1e1b544bed38cf009d5e9d
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-08-01T22:06:41Z

          CB-13057 : removed save function and updated unit-tests after these changes

          commit 799e14d032e5c59f9dca5ad5921155572b2e246e
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-08-01T22:07:52Z

          CB-13057 : removed platformsJson from integration tests


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/586 CB-13057 : Remove cordova platform save command <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Remove cordova platform save command What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13057 -2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/586.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #586 commit 3f66326f751de7c78f1e1b544bed38cf009d5e9d Author: Audrey So <audreyso@apache.org> Date: 2017-08-01T22:06:41Z CB-13057 : removed save function and updated unit-tests after these changes commit 799e14d032e5c59f9dca5ad5921155572b2e246e Author: Audrey So <audreyso@apache.org> Date: 2017-08-01T22:07:52Z CB-13057 : removed platformsJson from integration tests
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user audreyso opened a pull request:

          https://github.com/apache/cordova-lib/pull/585

          CB-13057 : added deprecation warning for cordova platform save

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?

          Added deprecation warning for cordova platform save

              1. What testing has been done on this change?
              1. Checklist
          • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [X] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/audreyso/cordova-lib CB-13057

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/585.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #585


          commit 5d9e3336071d00fc550cb1b042172466a0a86704
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-08-01T20:46:59Z

          CB-13057 : added deprecation warning for cordova platform save


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/585 CB-13057 : added deprecation warning for cordova platform save <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Added deprecation warning for cordova platform save What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-13057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/585.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #585 commit 5d9e3336071d00fc550cb1b042172466a0a86704 Author: Audrey So <audreyso@apache.org> Date: 2017-08-01T20:46:59Z CB-13057 : added deprecation warning for cordova platform save

            People

            • Assignee:
              auso Audrey So
              Reporter:
              stevegill Steve Gill
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development