Details

    Description

      Add deprecation notice for blackberry10 and ubuntu in cordova-lib. They aren't updating to platformAPI and we are going to fully drop support for them in cordova@8

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user audreyso opened a pull request:

            https://github.com/apache/cordova-lib/pull/546

            CB-12674 : Added deprecation notice for blackberry10 and ubuntu

            <!--
            Please make sure the checklist boxes are all checked before submitting the PR. The checklist
            is intended as a quick reference, for complete details please see our Contributor Guidelines:

            http://cordova.apache.org/contribute/contribute_guidelines.html

            Thanks!
            -->

                1. Platforms affected
                1. What does this PR do?

            Added deprecation notice for blackberry10 and ubuntu.

                1. What testing has been done on this change?
                1. Checklist
            • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
            • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
            • [X] Added automated test coverage as appropriate for this change.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/audreyso/cordova-lib CB-12674

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-lib/pull/546.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #546


            commit 633b5242c9ce2f0cd14e5151fa37075955f7007f
            Author: Audrey So <audreyso@apache.org>
            Date: 2017-04-19T20:31:38Z

            CB-12674 : Added deprecation notice for blackberry10 and ubuntu


            githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/546 CB-12674 : Added deprecation notice for blackberry10 and ubuntu <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Added deprecation notice for blackberry10 and ubuntu. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12674 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #546 commit 633b5242c9ce2f0cd14e5151fa37075955f7007f Author: Audrey So <audreyso@apache.org> Date: 2017-04-19T20:31:38Z CB-12674 : Added deprecation notice for blackberry10 and ubuntu
            githubbot ASF GitHub Bot added a comment -

            Github user codecov-io commented on the issue:

            https://github.com/apache/cordova-lib/pull/546

            1. [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=h1) Report
              > Merging 546(https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/93672b7fe9644e8b02d352364d7848deca3c3c69?src=pr&el=desc) will *increase* coverage by `<.01%`.
              > The diff coverage is `50%`.

            [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/546/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=tree)

            ```diff
            @@ Coverage Diff @@

              1. master #546 +/- ##
                ==========================================
                + Coverage 83.33% 83.33% +<.01%
                ==========================================
                Files 65 65
                Lines 5160 5162 +2
                Branches 1028 1029 +1
                ==========================================
                + Hits 4300 4302 +2
                Misses 860 860
                ```

            ------

            [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=continue).
            > *Legend* - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
            > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
            > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=footer). Last update [93672b7...633b524](https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

            githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/546 [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=h1 ) Report > Merging 546 ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=desc ) into [master] ( https://codecov.io/gh/apache/cordova-lib/commit/93672b7fe9644e8b02d352364d7848deca3c3c69?src=pr&el=desc ) will * increase * coverage by `<.01%`. > The diff coverage is `50%`. [! [Impacted file tree graph] ( https://codecov.io/gh/apache/cordova-lib/pull/546/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=tree ) ```diff @@ Coverage Diff @@ master #546 +/- ## ========================================== + Coverage 83.33% 83.33% +<.01% ========================================== Files 65 65 Lines 5160 5162 +2 Branches 1028 1029 +1 ========================================== + Hits 4300 4302 +2 Misses 860 860 ``` [Impacted Files] ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=tree ) Coverage Δ   — — — [cordova-lib/src/cordova/platform.js] ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM= ) `78% <50%> (+0.1%)` :arrow_up: ------ [Continue to review full report at Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=continue ). > * Legend * - [Click here to learn more] ( https://docs.codecov.io/docs/codecov-delta ) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=footer ). Last update [93672b7...633b524] ( https://codecov.io/gh/apache/cordova-lib/pull/546?src=pr&el=lastupdated ). Read the [comment docs] ( https://docs.codecov.io/docs/pull-request-comments ).

            Commit 3c2e8d2cf52d71f39478d3331d107ebd08cc9a40 in cordova-lib's branch refs/heads/master from auso
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3c2e8d2 ]

            CB-12674 : Added deprecation notice for blackberry10 and ubuntu

            This closes #546

            jira-bot ASF subversion and git services added a comment - Commit 3c2e8d2cf52d71f39478d3331d107ebd08cc9a40 in cordova-lib's branch refs/heads/master from auso [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=3c2e8d2 ] CB-12674 : Added deprecation notice for blackberry10 and ubuntu This closes #546
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-lib/pull/546

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/546

            People

              auso Audrey So
              stevegill Steve Gill
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: