Details

      Description

      Remove engineStrict from package.json. It is no longer supported.

      Error -->
      WARN engineStrict Per-package engineStrict (found in this package's package.json)
      npm WARN engineStrict won't be used in npm 3+. Use the config setting engine-strict instead.

        Issue Links

          Activity

          Hide
          auso Audrey So added a comment -

          Thanks!!! Shazron Abdullah

          Show
          auso Audrey So added a comment - Thanks!!! Shazron Abdullah
          Hide
          shazron Shazron Abdullah added a comment -

          Audrey So looks like all 3 PRs have been pulled in. Resolve this?

          Show
          shazron Shazron Abdullah added a comment - Audrey So looks like all 3 PRs have been pulled in. Resolve this?
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 742f9c0e1439e2433efb8a92f30126d3c5e1bfb0 in cordova-serve's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-serve.git;h=742f9c0 ]

          CB-12665 removed enginestrict since it is deprecated

          Show
          jira-bot ASF subversion and git services added a comment - Commit 742f9c0e1439e2433efb8a92f30126d3c5e1bfb0 in cordova-serve's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-serve.git;h=742f9c0 ] CB-12665 removed enginestrict since it is deprecated
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e700cd573f72a46c92e846f4620b488b0726c137 in cordova-fetch's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-fetch.git;h=e700cd5 ]

          CB-12665 removed enginestrict since it is deprecated

          Show
          jira-bot ASF subversion and git services added a comment - Commit e700cd573f72a46c92e846f4620b488b0726c137 in cordova-fetch's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-fetch.git;h=e700cd5 ] CB-12665 removed enginestrict since it is deprecated
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-cli/pull/275

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/275
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 132555ed64ae5fbe0d7d7421c3d2ab685f10d8cf in cordova-cli's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=132555e ]

          CB-12665 : removed engineStrict as it is no longer supported

          This closes #275

          Show
          jira-bot ASF subversion and git services added a comment - Commit 132555ed64ae5fbe0d7d7421c3d2ab685f10d8cf in cordova-cli's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=132555e ] CB-12665 : removed engineStrict as it is no longer supported This closes #275
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a3d76a35a17245dfef79259047bf35656b9bb65d in cordova-lib's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a3d76a3 ]

          CB-12665 removed enginestrict since it is deprecated

          Show
          jira-bot ASF subversion and git services added a comment - Commit a3d76a35a17245dfef79259047bf35656b9bb65d in cordova-lib's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a3d76a3 ] CB-12665 removed enginestrict since it is deprecated
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-lib/pull/544

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/544
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c0b8ce214500ed6da3a67903481bc15e945e33f4 in cordova-lib's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c0b8ce2 ]

          CB-12665 : removed engineStrict as it is no longer supported

          This closes #544

          Show
          jira-bot ASF subversion and git services added a comment - Commit c0b8ce214500ed6da3a67903481bc15e945e33f4 in cordova-lib's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c0b8ce2 ] CB-12665 : removed engineStrict as it is no longer supported This closes #544
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-ios/pull/306

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/306
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e7ed5b9f4af60cc0e4a40a5c85338fa51f4e0e86 in cordova-ios's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=e7ed5b9 ]

          CB-12665 : removing engineStrict as it is no longer supported

          This closes #306

          Show
          jira-bot ASF subversion and git services added a comment - Commit e7ed5b9f4af60cc0e4a40a5c85338fa51f4e0e86 in cordova-ios's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=e7ed5b9 ] CB-12665 : removing engineStrict as it is no longer supported This closes #306
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user codecov-io commented on the issue:

          https://github.com/apache/cordova-lib/pull/544

          1. [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=h1) Report
            > Merging 544(https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/d2b636a98e4d1a8c8f7199897b7ac09b6cccc59f?src=pr&el=desc) will *not change* coverage.
            > The diff coverage is `n/a`.

          [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/544/graphs/tree.svg?height=150&width=650&token=KwBjKMXLqA&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=tree)

          ```diff
          @@ Coverage Diff @@

            1. master #544 +/- ##
              =======================================
              Coverage 82.42% 82.42%
              =======================================
              Files 68 68
              Lines 5462 5462
              Branches 1072 1072
              =======================================
              Hits 4502 4502
              Misses 960 960
              ```

          ------

          [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=continue).
          > *Legend* - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
          > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
          > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=footer). Last update [d2b636a...9899fa1](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

          Show
          githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/544 [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=h1 ) Report > Merging 544 ( https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=desc ) into [master] ( https://codecov.io/gh/apache/cordova-lib/commit/d2b636a98e4d1a8c8f7199897b7ac09b6cccc59f?src=pr&el=desc ) will * not change * coverage. > The diff coverage is `n/a`. [! [Impacted file tree graph] ( https://codecov.io/gh/apache/cordova-lib/pull/544/graphs/tree.svg?height=150&width=650&token=KwBjKMXLqA&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=tree ) ```diff @@ Coverage Diff @@ master #544 +/- ## ======================================= Coverage 82.42% 82.42% ======================================= Files 68 68 Lines 5462 5462 Branches 1072 1072 ======================================= Hits 4502 4502 Misses 960 960 ``` ------ [Continue to review full report at Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=continue ). > * Legend * - [Click here to learn more] ( https://docs.codecov.io/docs/codecov-delta ) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=footer ). Last update [d2b636a...9899fa1] ( https://codecov.io/gh/apache/cordova-lib/pull/544?src=pr&el=lastupdated ). Read the [comment docs] ( https://docs.codecov.io/docs/pull-request-comments ).
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user audreyso opened a pull request:

          https://github.com/apache/cordova-lib/pull/544

          CB-12665 : removed engineStrict as it is no longer supported

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?

          Removed engineStrict as it is no longer supported.

              1. What testing has been done on this change?
              1. Checklist
          • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [X] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/audreyso/cordova-lib CB-12665

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/544.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #544


          commit 9899fa1df5de5ceee1f4c1e031d31e050c69250c
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-04-17T22:54:11Z

          CB-12665 : removed engineStrict as it is no longer supported


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/544 CB-12665 : removed engineStrict as it is no longer supported <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Removed engineStrict as it is no longer supported. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-12665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/544.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #544 commit 9899fa1df5de5ceee1f4c1e031d31e050c69250c Author: Audrey So <audreyso@apache.org> Date: 2017-04-17T22:54:11Z CB-12665 : removed engineStrict as it is no longer supported
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user audreyso opened a pull request:

          https://github.com/apache/cordova-cli/pull/275

          CB-12665 : removed engineStrict as it is no longer supported

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?

          Removed engineStrict as it is no longer supported.

              1. What testing has been done on this change?
              1. Checklist
          • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [X] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/audreyso/cordova-cli CB-12665

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-cli/pull/275.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #275


          commit fc62925212754993c3e76984b9d0620afaa7a149
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-04-17T22:58:36Z

          CB-12665 : removed engineStrict as it is no longer supported


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/275 CB-12665 : removed engineStrict as it is no longer supported <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Removed engineStrict as it is no longer supported. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-cli CB-12665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 commit fc62925212754993c3e76984b9d0620afaa7a149 Author: Audrey So <audreyso@apache.org> Date: 2017-04-17T22:58:36Z CB-12665 : removed engineStrict as it is no longer supported
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user audreyso opened a pull request:

          https://github.com/apache/cordova-ios/pull/306

          CB-12665 : removing engineStrict as it is no longer supported

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?

          Removing engineStrict as it is no longer supported.

              1. What testing has been done on this change?
              1. Checklist
          • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [X] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/audreyso/cordova-ios CB-12665

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-ios/pull/306.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #306


          commit 11d7d4ed67fee982baf0f7e5de8c39613f9db4df
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-04-17T22:41:19Z

          CB-12665 : removing engineStrict as it is no longer supported


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-ios/pull/306 CB-12665 : removing engineStrict as it is no longer supported <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Removing engineStrict as it is no longer supported. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-ios CB-12665 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/306.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #306 commit 11d7d4ed67fee982baf0f7e5de8c39613f9db4df Author: Audrey So <audreyso@apache.org> Date: 2017-04-17T22:41:19Z CB-12665 : removing engineStrict as it is no longer supported

            People

            • Assignee:
              Unassigned
              Reporter:
              auso Audrey So
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development