Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-12542

can’t record to a “wav” file on IOS media plugin

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: None
    • Component/s: cordova-plugin-media
    • Labels:
    • Environment:

      9.x Simulator , IOS 8.x device (iPod touch)

      Description

      I get “Failed to initialize AVAudioRecorder: (null)” in the error callback of the startRecordingAudio() exec API.
      I see that the AVAudioPlayer settings in CDVAudio.m are

      NSDictionary *audioSettings = @{AVFormatIDKey: @(kAudioFormatMPEG4AAC),
                                                  AVSampleRateKey: @(44100),
                                                  AVNumberOfChannelsKey: @(1),
                                                  AVEncoderAudioQualityKey: @(AVAudioQualityMedium)
                                                  };
      

      This is IMHO the reason it doesn’t work. Either one uses the .m4a extension with kAudioFormatMPEG4AAC or
      .wav with the kAudioFormatLinearPCM key (the IOS docs are very unclear about which file extensions are actually supported)

      The plugin enforces “wav” but the settings enforce the MPEG4AAC encoder.
      Using the attached simple patch and using .m4a at the JS side solves the problem and records on my iPod touch IOS 8.x.

      I stumbled also across https://github.com/remoorejr/cordova-plugin-media-with-compression where the exchange wav->m4a is done too.

      Strangely I can’t find much problems reported on stackoverflow, but this one seems to cover it
      http://stackoverflow.com/questions/12244111/failed-to-initialize-avaudiorecorder-null
      The last poster seem to indicate that the problem sneaked in in IOS 8 (previously it was probably possible to record to a .wav file but with AAC content).

      Looking at the recordAudio() test for the plugin in tests/tests.js I can’t see that potential errors are actually causing the test to fail: they are just logged with console.log , so this may explain why the problem has not been detected by the tests.

      1. cdvsound.diff
        1.0 kB
        Leo Schubert

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shazron opened a pull request:

          https://github.com/apache/cordova-plugin-media/pull/132

          CB-12542 - Can't record to a wav file

          Thanks to Leo Schubert for this patch (see JIRA issue).

              1. Platforms affected

          iOS

              1. What does this PR do?

          Change the file extension of the file being recorded to .m4a (AAC)

              1. What testing has been done on this change?

          cordova-paramedic local test on iOS (flaky). I plan to let the CI run the device tests.

              1. Checklist
          • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [X] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shazron/cordova-plugin-media CB-12542

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-media/pull/132.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #132


          commit b77adb2fb8f0cf8fd72352959bbdc3b9b76e2791
          Author: Shazron Abdullah <shazron@gmail.com>
          Date: 2017-03-09T19:18:41Z

          CB-12542 - Can't record to a wav file

          Thanks to Leo Schubert (ls at 4js dot com) for this patch.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-media/pull/132 CB-12542 - Can't record to a wav file Thanks to Leo Schubert for this patch (see JIRA issue). Platforms affected iOS What does this PR do? Change the file extension of the file being recorded to .m4a (AAC) What testing has been done on this change? cordova-paramedic local test on iOS (flaky). I plan to let the CI run the device tests. Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: " CB-3232 : (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-media CB-12542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit b77adb2fb8f0cf8fd72352959bbdc3b9b76e2791 Author: Shazron Abdullah <shazron@gmail.com> Date: 2017-03-09T19:18:41Z CB-12542 - Can't record to a wav file Thanks to Leo Schubert (ls at 4js dot com) for this patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/132

          let there be tests!

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 let there be tests!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/132

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/132/commits/b77adb2fb8f0cf8fd72352959bbdc3b9b76e2791)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/artifact/)
          [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/artifact/)
          [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/artifact/)
          [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/artifact/)
          [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/artifact/)
          Show
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/132/commits/b77adb2fb8f0cf8fd72352959bbdc3b9b76e2791 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=windows-10-store/artifact/ ) [iOS 9.3] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-9.3/artifact/ ) [iOS 10.0] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=ios-10.0/artifact/ ) [Android 4.4] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-4.4/artifact/ ) [Android 5.1] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/102//PLATFORM=android-5.1/artifact/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jcesarmobile commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/132

          Can we have wav and m4a as in https://github.com/apache/cordova-plugin-media/pull/131?
          In any case, the README.md needs an update, right now it says that iOS only accept wav, which won't be true after this change

          Show
          githubbot ASF GitHub Bot added a comment - Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 Can we have wav and m4a as in https://github.com/apache/cordova-plugin-media/pull/131? In any case, the README.md needs an update, right now it says that iOS only accept wav, which won't be true after this change
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/132

          #131 does have a better way than this and enables like you said multi format recording. That PR has issues and I have commented on it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 #131 does have a better way than this and enables like you said multi format recording. That PR has issues and I have commented on it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user leopatras opened a pull request:

          https://github.com/apache/cordova-plugin-media/pull/134

          CB-12542: (ios) Fix wav file recording, add m4a extension

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
                IOS
              1. What does this PR do?
                Fix https://issues.apache.org/jira/browse/CB-12542
              1. What testing has been done on this change?
                Tested that a wav or an m4a file can be recorded/played
              1. Checklist
          • [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [ ] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/leopatras/cordova-plugin-media development

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-media/pull/134.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #134


          commit 5d7b4e3fe7fe6445c675e5754507b62b321807f0
          Author: Leo Schubert <ls@4js.com>
          Date: 2017-03-11T09:49:28Z

          CB-12542: (ios) Fix wav file recording, add m4a extension


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user leopatras opened a pull request: https://github.com/apache/cordova-plugin-media/pull/134 CB-12542 : (ios) Fix wav file recording, add m4a extension <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected IOS What does this PR do? Fix https://issues.apache.org/jira/browse/CB-12542 What testing has been done on this change? Tested that a wav or an m4a file can be recorded/played Checklist [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: " CB-3232 : (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/leopatras/cordova-plugin-media development Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 5d7b4e3fe7fe6445c675e5754507b62b321807f0 Author: Leo Schubert <ls@4js.com> Date: 2017-03-11T09:49:28Z CB-12542 : (ios) Fix wav file recording, add m4a extension
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/134/commits/5d7b4e3fe7fe6445c675e5754507b62b321807f0)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/artifact/)
          [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/artifact/)
          [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/artifact/)
          [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/artifact/)
          [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/artifact/)
          Show
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/134/commits/5d7b4e3fe7fe6445c675e5754507b62b321807f0 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=windows-10-store/artifact/ ) [iOS 9.3] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-9.3/artifact/ ) [iOS 10.0] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=ios-10.0/artifact/ ) [Android 4.4] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-4.4/artifact/ ) [Android 5.1] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/108//PLATFORM=android-5.1/artifact/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user LoneyGG commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Why this hasn't been merged yet? its a pain to apply the fix manually and remove this plugin from the gitignore in order to share my code with my partners.

          Show
          githubbot ASF GitHub Bot added a comment - Github user LoneyGG commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Why this hasn't been merged yet? its a pain to apply the fix manually and remove this plugin from the gitignore in order to share my code with my partners.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Cordova CI Build has one or more failures.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/134/commits/80cbffe9bc620df72090ae60b5360b874f8a3b86)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/artifact/)
          [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/artifact/)
          [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/artifact/)
          [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/artifact/)
          [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/artifact/)
          Show
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Cordova CI Build has one or more failures. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/134/commits/80cbffe9bc620df72090ae60b5360b874f8a3b86 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=windows-10-store/artifact/ ) [iOS 9.3] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-9.3/artifact/ ) [iOS 10.0] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=ios-10.0/artifact/ ) [Android 4.4] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-4.4/artifact/ ) [Android 5.1] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/111//PLATFORM=android-5.1/artifact/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/134/commits/5d7b4e3fe7fe6445c675e5754507b62b321807f0)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/artifact/)
          [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/artifact/)
          [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/artifact/)
          [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/artifact/)
          [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/artifact/)
          Show
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/134/commits/5d7b4e3fe7fe6445c675e5754507b62b321807f0 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=windows-10-store/artifact/ ) [iOS 9.3] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-9.3/artifact/ ) [iOS 10.0] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=ios-10.0/artifact/ ) [Android 4.4] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-4.4/artifact/ ) [Android 5.1] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/112//PLATFORM=android-5.1/artifact/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/134/commits/5ac3e6f04366dfc035e80f7bd40f183db5dc8436)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/artifact/)
          [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/artifact/)
          [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/artifact/)
          [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/artifact/)
          [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/artifact/)
          Show
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/134/commits/5ac3e6f04366dfc035e80f7bd40f183db5dc8436 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=windows-10-store/artifact/ ) [iOS 9.3] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-9.3/artifact/ ) [iOS 10.0] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=ios-10.0/artifact/ ) [Android 4.4] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-4.4/artifact/ ) [Android 5.1] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/113//PLATFORM=android-5.1/artifact/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/134/commits/035e7dd2c6311483b57de809bd7a416ea12627af)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/artifact/)
          [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/artifact/)
          [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/artifact/)
          [Android 4.4]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/artifact/)
          [Android 5.1]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/artifact/)
          Show
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/134/commits/035e7dd2c6311483b57de809bd7a416ea12627af ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=windows-10-store/artifact/ ) [iOS 9.3] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-9.3/artifact/ ) [iOS 10.0] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=ios-10.0/artifact/ ) [Android 4.4] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-4.4/artifact/ ) [Android 5.1] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/114//PLATFORM=android-5.1/artifact/ )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user leopatras commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          @shazron What prevents the pull request from being merged ? Anything I can do further ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user leopatras commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 @shazron What prevents the pull request from being merged ? Anything I can do further ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user LoneyGG commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          @shazron Please review this pull request, is working perfectly and hasn't been merged yet!

          Show
          githubbot ASF GitHub Bot added a comment - Github user LoneyGG commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 @shazron Please review this pull request, is working perfectly and hasn't been merged yet!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Iyashu5040 commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Thanks so much @leopatras for this fix. I'm using your version of this plugin while we wait for the PR to be merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Iyashu5040 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Thanks so much @leopatras for this fix. I'm using your version of this plugin while we wait for the PR to be merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dylanvdmerwe commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Please can someone review this PR. This is a very suitable fix for a real problem.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dylanvdmerwe commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Please can someone review this PR. This is a very suitable fix for a real problem.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/132

          @shazron @jcesarmobile How does this relate to #134 ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 @shazron @jcesarmobile How does this relate to #134 ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/132

          @shazron @jcesarmobile #134 also supports both m4a and wav formats, and I think is a decent PR. Refactors some bits and looks to have a lot of community support. I think we should switch efforts to focus on merging that PR. Thoughts?

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/132 @shazron @jcesarmobile #134 also supports both m4a and wav formats, and I think is a decent PR. Refactors some bits and looks to have a lot of community support. I think we should switch efforts to focus on merging that PR. Thoughts?
          Hide
          filmaj Filip Maj added a comment -

          Sounds like we should go ahead with #134 according to Shazron Abdullah

          Show
          filmaj Filip Maj added a comment - Sounds like we should go ahead with #134 according to Shazron Abdullah
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron closed the pull request at:

          https://github.com/apache/cordova-plugin-media/pull/132

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/132
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          I am taking a look at this today. Will rebase and run some tests locally.

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 I am taking a look at this today. Will rebase and run some tests locally.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          @leopatras while I verify this PR, do you have an [Apache ICLA](https://www.apache.org/licenses/icla.pdf) signed and sent to secretary@apache.org?

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 @leopatras while I verify this PR, do you have an [Apache ICLA] ( https://www.apache.org/licenses/icla.pdf ) signed and sent to secretary@apache.org?
          Hide
          leopatras Leo Schubert added a comment - - edited

          Filip Majyes I have a signed Apache ICLA. I got an e-mail from Craig L Russel saying
          "With this message, the Cordova PMC has been notified that your ICLA has been filed."
          So please ask the Cordova PMC (because I don't know who this is

          Show
          leopatras Leo Schubert added a comment - - edited Filip Maj yes I have a signed Apache ICLA. I got an e-mail from Craig L Russel saying "With this message, the Cordova PMC has been notified that your ICLA has been filed." So please ask the Cordova PMC (because I don't know who this is
          Hide
          filmaj Filip Maj added a comment -

          Excellent, yes, I see that you are on the list here: http://people.apache.org/unlistedclas.html

          I am just testing your PR out. Works for .wav! I am about to test w/ .m4a.

          Show
          filmaj Filip Maj added a comment - Excellent, yes, I see that you are on the list here: http://people.apache.org/unlistedclas.html I am just testing your PR out. Works for .wav! I am about to test w/ .m4a.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          OK, verified this works with both .wav and .m4a on an iPhone 5S running iOS 10.2. Hooray!

          I will be rebasing and pulling this in shortly, and then will close this PR separately. Will report back soon.

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 OK, verified this works with both .wav and .m4a on an iPhone 5S running iOS 10.2. Hooray! I will be rebasing and pulling this in shortly, and then will close this PR separately. Will report back soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Actually, I spoke too soon. I think I will pull in everything but the last commit - that seems like a new command being added.

          I will retest with all commits but that last one that adds `getDurationAudio`. @leopatras can you elaborate on what this command is all about, in the mean time?

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Actually, I spoke too soon. I think I will pull in everything but the last commit - that seems like a new command being added. I will retest with all commits but that last one that adds `getDurationAudio`. @leopatras can you elaborate on what this command is all about, in the mean time?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Here are the relevant bits of test code I am working with:

          ```
          initialize: function() {
          document.addEventListener('deviceready', this.onDeviceReady.bind(this), false);
          document.getElementById('record_start').addEventListener('touchstart', function(evt)

          { myMedia.startRecord(); }

          );
          document.getElementById('record_stop').addEventListener('touchstart', function(evt)

          { myMedia.stopRecord(); }

          );
          document.getElementById('play').addEventListener('touchstart', function(evt)

          { myMedia.play(); }

          );
          document.getElementById('stop').addEventListener('touchstart', function(evt)

          { myMedia.stop(); }

          );
          },

          // deviceready Event Handler
          //
          // Bind any cordova events here. Common events are:
          // 'pause', 'resume', etc.
          onDeviceReady: function() {
          this.receivedEvent('deviceready');
          status = document.getElementById('status');
          myMedia = new Media("documents://beer.m4a", function(evt) {
          }, function(err) {
          });
          },
          ```

          Confirmed that without the last commit, the above, for both .wav and .m4a files, works.

          So, I am happy to pull in the first two commits in this PR, but I would like more clarification from @leopatras on the last commit and the new undocumented command it adds to iOS.

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Here are the relevant bits of test code I am working with: ``` initialize: function() { document.addEventListener('deviceready', this.onDeviceReady.bind(this), false); document.getElementById('record_start').addEventListener('touchstart', function(evt) { myMedia.startRecord(); } ); document.getElementById('record_stop').addEventListener('touchstart', function(evt) { myMedia.stopRecord(); } ); document.getElementById('play').addEventListener('touchstart', function(evt) { myMedia.play(); } ); document.getElementById('stop').addEventListener('touchstart', function(evt) { myMedia.stop(); } ); }, // deviceready Event Handler // // Bind any cordova events here. Common events are: // 'pause', 'resume', etc. onDeviceReady: function() { this.receivedEvent('deviceready'); status = document.getElementById('status'); myMedia = new Media("documents://beer.m4a", function(evt) { }, function(err) { }); }, ``` Confirmed that without the last commit, the above, for both .wav and .m4a files, works. So, I am happy to pull in the first two commits in this PR, but I would like more clarification from @leopatras on the last commit and the new undocumented command it adds to iOS.
          Hide
          leopatras Leo Schubert added a comment -

          Filip Maj 'getDurationAudio' was added to be on par with Android (Its there in the native plugin sources in AudioHandler.java)

          else if (action.equals("getDurationAudio")) {
                      float f = this.getDurationAudio(args.getString(0), args.getString(1));
                      callbackContext.sendPluginResult(new PluginResult(status, f));
                      return true;
                  }
          

          I must admit that we are aliens not using the JS interface at all , we are using a language called Genero 4GL directly calling the native plugins...
          I should have added a function wrapper in www/Media.js like this

          Media.prototype.getDurationAudio = function(success, fail) {
              exec(function(p) {
                  success(p);
              }, fail, "Media", "getDurationAudio", [this.id]);
          };
          

          The problem with getDuration (withoutAudio) is you can't get the duration before playing that file.
          You only get a valid duration upon you started playing
          Hope that clarifies.

          Show
          leopatras Leo Schubert added a comment - Filip Maj 'getDurationAudio' was added to be on par with Android (Its there in the native plugin sources in AudioHandler.java) else if (action.equals( "getDurationAudio" )) { float f = this .getDurationAudio(args.getString(0), args.getString(1)); callbackContext.sendPluginResult( new PluginResult(status, f)); return true ; } I must admit that we are aliens not using the JS interface at all , we are using a language called Genero 4GL directly calling the native plugins... I should have added a function wrapper in www/Media.js like this Media.prototype.getDurationAudio = function(success, fail) { exec(function(p) { success(p); }, fail, "Media" , "getDurationAudio" , [ this .id]); }; The problem with getDuration (withoutAudio) is you can't get the duration before playing that file. You only get a valid duration upon you started playing Hope that clarifies.
          Hide
          filmaj Filip Maj added a comment -

          Leo Schubert thanks, that does clarify quite a bit.

          May I recommend filing a separate issue with respect to the limitation you describe about getDuration (feel free to link to this issue as well)?

          This let's us keep the behaviours focused on separate features.

          In the mean time, I will merge in the PR regarding wav and m4a support.

          Show
          filmaj Filip Maj added a comment - Leo Schubert thanks, that does clarify quite a bit. May I recommend filing a separate issue with respect to the limitation you describe about getDuration (feel free to link to this issue as well)? This let's us keep the behaviours focused on separate features. In the mean time, I will merge in the PR regarding wav and m4a support.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user filmaj commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/134

          Per CB-12542(https://issues.apache.org/jira/browse/CB-12542), I will merge in the wav/m4a support, and we will look at the separate `getDuration` issue @leopatras described in the JIRA in a separate issue thread / pull request.

          Show
          githubbot ASF GitHub Bot added a comment - Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Per CB-12542 ( https://issues.apache.org/jira/browse/CB-12542 ), I will merge in the wav/m4a support, and we will look at the separate `getDuration` issue @leopatras described in the JIRA in a separate issue thread / pull request.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b61d97cd718f989f4b16fa3ee52c5c0095538008 in cordova-plugin-media's branch refs/heads/master from Leo Schubert
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=b61d97c ]

          CB-12542: (ios) Fix wav file recording, add m4a extension. make IOS status handling compatible with Android/Windows

          implement a "messageChannel" command and if the messageChannel
          command is called the plugin hands back results to the plugin
          container via "sendPluginResult" instead of "evalJs"
          even for oldschool usage it cleans the code

          Closes #134.

          Show
          jira-bot ASF subversion and git services added a comment - Commit b61d97cd718f989f4b16fa3ee52c5c0095538008 in cordova-plugin-media's branch refs/heads/master from Leo Schubert [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=b61d97c ] CB-12542 : (ios) Fix wav file recording, add m4a extension. make IOS status handling compatible with Android/Windows implement a "messageChannel" command and if the messageChannel command is called the plugin hands back results to the plugin container via "sendPluginResult" instead of "evalJs" even for oldschool usage it cleans the code Closes #134.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-plugin-media/pull/134

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/134
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b61d97cd718f989f4b16fa3ee52c5c0095538008 in cordova-plugin-media's branch refs/heads/3.0.x from Leo Schubert
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=b61d97c ]

          CB-12542: (ios) Fix wav file recording, add m4a extension. make IOS status handling compatible with Android/Windows

          implement a "messageChannel" command and if the messageChannel
          command is called the plugin hands back results to the plugin
          container via "sendPluginResult" instead of "evalJs"
          even for oldschool usage it cleans the code

          Closes #134.

          Show
          jira-bot ASF subversion and git services added a comment - Commit b61d97cd718f989f4b16fa3ee52c5c0095538008 in cordova-plugin-media's branch refs/heads/3.0.x from Leo Schubert [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=b61d97c ] CB-12542 : (ios) Fix wav file recording, add m4a extension. make IOS status handling compatible with Android/Windows implement a "messageChannel" command and if the messageChannel command is called the plugin hands back results to the plugin container via "sendPluginResult" instead of "evalJs" even for oldschool usage it cleans the code Closes #134.

            People

            • Assignee:
              filmaj Filip Maj
              Reporter:
              leopatras Leo Schubert
            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development