Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Won't Fix
-
None
Description
The plugin install flow doesn't wait for https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L183 promise to complete. Need to audit the promise flow here and fix it.
UPDATE:
This seems to be an issue due to platform level scripts doing async operations. They shell out and don't wait for promises to resolve. Marking this as won't fix since we should really review all platform level scripts to make sure they are synchronous
Attachments
Issue Links
- links to
Activity
Chris Wells
made changes -
Workflow | Classic - editable closed [ 14067397 ] | classic default workflow [ 14088141 ] |
Chris Wells
made changes -
Workflow | classic default workflow [ 13236399 ] | Classic - editable closed [ 14067397 ] |
Steve Gill
made changes -
Fix Version/s | cordova@7.0.0 [ 12340557 ] |
Shazron Abdullah
made changes -
Component/s | cordova-lib [ 12332428 ] | |
Component/s | CordovaLib [ 12322657 ] |
Steve Gill
made changes -
Resolution | Won't Fix [ 2 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Steve Gill
made changes -
Description | The plugin install flow doesn't wait for https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L183 promise to complete. Need to audit the promise flow here and fix it. |
The plugin install flow doesn't wait for https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L183 promise to complete. Need to audit the promise flow here and fix it. UPDATE: This seems to be an issue due to platform level scripts doing async operations. They shell out and don't wait for promises to resolve. Marking this as won't fix since we should really review all platform level scripts to make sure they are synchronous |
Audrey So
made changes -
Assignee | Audrey So [ auso ] |
ASF GitHub Bot
made changes -
Field | Original Value | New Value |
---|---|---|
Remote Link | This issue links to "GitHub Pull Request #499 (Web Link)" [ 62387 ] |
Steve Gill
created issue -
Commit a9605411ab007d700849c971043f0c211c06100c in cordova-lib's branch refs/heads/master from Audrey So
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a960541 ]
CB-11960: updated android versions to 6.1.1., removed ios platforms for testing and replaced with browser, added includes function to support node 4. Test 005 commented out because not promisified correctly (CB-12170).This closes #499