Details

    Description

      The plugin install flow doesn't wait for https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L183 promise to complete. Need to audit the promise flow here and fix it.

      UPDATE:
      This seems to be an issue due to platform level scripts doing async operations. They shell out and don't wait for promises to resolve. Marking this as won't fix since we should really review all platform level scripts to make sure they are synchronous

      Attachments

        Activity

          iroh Chris Wells made changes -
          Workflow Classic - editable closed [ 14067397 ] classic default workflow [ 14088141 ]
          iroh Chris Wells made changes -
          Workflow classic default workflow [ 13236399 ] Classic - editable closed [ 14067397 ]
          stevegill Steve Gill made changes -
          Fix Version/s cordova@7.0.0 [ 12340557 ]
          shazron Shazron Abdullah made changes -
          Component/s cordova-lib [ 12332428 ]
          Component/s CordovaLib [ 12322657 ]
          stevegill Steve Gill made changes -
          Resolution Won't Fix [ 2 ]
          Status Open [ 1 ] Closed [ 6 ]
          stevegill Steve Gill made changes -
          Description The plugin install flow doesn't wait for https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L183 promise to complete. Need to audit the promise flow here and fix it. The plugin install flow doesn't wait for https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/fetch.js#L183 promise to complete. Need to audit the promise flow here and fix it.

          UPDATE:
          This seems to be an issue due to platform level scripts doing async operations. They shell out and don't wait for promises to resolve. Marking this as won't fix since we should really review all platform level scripts to make sure they are synchronous
          auso Audrey So made changes -
          Assignee Audrey So [ auso ]

          Commit a9605411ab007d700849c971043f0c211c06100c in cordova-lib's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a960541 ]

          CB-11960 : updated android versions to 6.1.1., removed ios platforms for testing and replaced with browser, added includes function to support node 4. Test 005 commented out because not promisified correctly (CB-12170).

          This closes #499

          jira-bot ASF subversion and git services added a comment - Commit a9605411ab007d700849c971043f0c211c06100c in cordova-lib's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=a960541 ] CB-11960 : updated android versions to 6.1.1., removed ios platforms for testing and replaced with browser, added includes function to support node 4. Test 005 commented out because not promisified correctly ( CB-12170 ). This closes #499
          githubbot ASF GitHub Bot added a comment -

          Github user stevengill commented on the issue:

          https://github.com/apache/cordova-lib/pull/499

          Test 005 may periodically fail due to https://issues.apache.org/jira/browse/CB-12170

          githubbot ASF GitHub Bot added a comment - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/499 Test 005 may periodically fail due to https://issues.apache.org/jira/browse/CB-12170
          githubbot ASF GitHub Bot made changes -
          Field Original Value New Value
          Remote Link This issue links to "GitHub Pull Request #499 (Web Link)" [ 62387 ]
          stevegill Steve Gill created issue -

          People

            auso Audrey So
            stevegill Steve Gill
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment