[CB-12130] Launch storyboard images are not updated or cleaned

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Master, 4.3.0
• Fix Version/s: cordova-ios@4.3.1
• Component/s: cordova-ios
• Assignee: Kerri Shotts
• Reporter: Niels Leenheer
• Created: 10/Nov/16 14:46
• Updated: 23/Aug/18 06:51
• Resolved: 16/Nov/16 05:26

Description

Launch storyboard images were not updated or cleaned in
updateLaunchStoryboardImages() or cleanLaunchStoryboardImages()
because the check for Images.xcassets in
getLaunchStoryboardImagesDir() failed.

The reason was that the platformProjDir and projectRoot were
joined, while both were relative to the root directory. So the
resulting directory was non-sensical. This changes makes
platformProjDir relative to cordovaProject.root, which matches the
same check in updateSplashScreens() and updateIcons().

Issue Links

• relates to: CB-9762 App icon and Launch image for iPad Pro
• links to: GitHub Pull Request #276