[CB-12036] Exception on prepare when no SplashScreen node not found in manifest

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.4.3
• Component/s: cordova-windows
• External issue URL: https://github.com/apache/cordova-windows/pull/196
• Assignee: Unassigned
• Reporter: Giuseppe La Torre
• Created: 19/Oct/16 15:54
• Updated: 23/Aug/18 06:49
• Resolved: 21/Oct/16 12:01

Description

This is a mirror of the pull: https://github.com/apache/cordova-windows/pull/196

The issue is:
running prepare, the function setSplashBgColor on AppManifest.js throws exception when then splashscreen node is not found in the manifest.

The scenario:
Windows allows to have an app with NO splashscreen at all. You can either remove the node manually or, like me, use a hook to remove it because cordova actually doesn't support such a feature.
So, the code in that function crashes because it assumes a splashscreen exists, but the node is optional in the manifest.
The solution is easy: check if the node exists before doing stuff. No more than that. The pull request implements that simply if.

Please, don't delay because the missing feature. The issue is beyond that, the code is wrong because the assumption is false.

Issue Links

• links to: GitHub Pull Request #196