Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: CordovaJS, CordovaLib
    • Labels:

      Description

      Lets update our deps for cordova-lib and cordova-js

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user stevengill opened a pull request:

          https://github.com/apache/cordova-js/pull/139

          CB-12017: updated dependencies in package.json

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
                cordova-js
              1. What does this PR do?
                updates outdated dependencies, fixes security issues with old versions of dependencies.
              1. What testing has been done on this change?
                npm test
              1. Checklist
          • [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [ ] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/stevengill/cordova-js CB-12017

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-js/pull/139.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #139


          commit 4f28160d2c4e9f5d5f4148bb5ff6cd2c58904ce3
          Author: Steve Gill <stevengill97@gmail.com>
          Date: 2016-10-14T03:00:59Z

          CB-12017: updated dependencies in package.json


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user stevengill opened a pull request: https://github.com/apache/cordova-js/pull/139 CB-12017 : updated dependencies in package.json <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected cordova-js What does this PR do? updates outdated dependencies, fixes security issues with old versions of dependencies. What testing has been done on this change? npm test Checklist [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: " CB-3232 : (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-js CB-12017 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit 4f28160d2c4e9f5d5f4148bb5ff6cd2c58904ce3 Author: Steve Gill <stevengill97@gmail.com> Date: 2016-10-14T03:00:59Z CB-12017 : updated dependencies in package.json
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e8d02c25143b9ca985729664e541d99335713dd9 in cordova-lib's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=e8d02c2 ]

          CB-12017: update istanbul dependency

          Show
          jira-bot ASF subversion and git services added a comment - Commit e8d02c25143b9ca985729664e541d99335713dd9 in cordova-lib's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=e8d02c2 ] CB-12017 : update istanbul dependency
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f28234fbc27c578b9a335f1dabfa2d1b96bfc03d in cordova-js's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=f28234f ]

          CB-12017: updated dependencies in package.json

          This closes #139

          Show
          jira-bot ASF subversion and git services added a comment - Commit f28234fbc27c578b9a335f1dabfa2d1b96bfc03d in cordova-js's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=f28234f ] CB-12017 : updated dependencies in package.json This closes #139
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-js/pull/139

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/139
          Hide
          ankon Andreas Kohn added a comment -

          The npm dependency is horribly old by now, and triggers this warning in our build:

          npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
          
          $ npm ls graceful-fs
          app
          ├─┬ cordova@6.4.0
          │ └─┬ cordova-lib@6.4.0
          │   └─┬ npm@2.15.11
          │     └── graceful-fs@4.1.6 
          
          Show
          ankon Andreas Kohn added a comment - The npm dependency is horribly old by now, and triggers this warning in our build: npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree. $ npm ls graceful-fs app ├─┬ cordova@6.4.0 │ └─┬ cordova-lib@6.4.0 │ └─┬ npm@2.15.11 │ └── graceful-fs@4.1.6
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user audreyso opened a pull request:

          https://github.com/apache/cordova-js/pull/141

          CB-12017 : updated npm dependency for browserify

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?

          Updated npm dependency for browserify.

              1. What testing has been done on this change?
              1. Checklist
          • [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [ ] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/audreyso/cordova-js CB-12017

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-js/pull/141.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #141


          commit 0c0485254be0064b61d4c54c4bc3a13a89c62622
          Author: Audrey So <audreyso@apache.org>
          Date: 2017-02-03T23:05:03Z

          CB-12017 : updated dependencies for browserify


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-js/pull/141 CB-12017 : updated npm dependency for browserify <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Updated npm dependency for browserify. What testing has been done on this change? Checklist [ ] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [ ] Commit message follows the format: " CB-3232 : (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-js CB-12017 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 0c0485254be0064b61d4c54c4bc3a13a89c62622 Author: Audrey So <audreyso@apache.org> Date: 2017-02-03T23:05:03Z CB-12017 : updated dependencies for browserify
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 744f44329016a90c580337e7c6d9e186392729b4 in cordova-lib's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=744f443 ]

          CB-12017 : updated dependencies rewire and request

          Show
          jira-bot ASF subversion and git services added a comment - Commit 744f44329016a90c580337e7c6d9e186392729b4 in cordova-lib's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=744f443 ] CB-12017 : updated dependencies rewire and request
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7235aeb0c6e4641bd858cd2e393e5552d8f229c9 in cordova-lib's branch refs/heads/master from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7235aeb ]

          CB-12017 : removed updated npm version due to fails after rebasing from master

          This closes #517

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7235aeb0c6e4641bd858cd2e393e5552d8f229c9 in cordova-lib's branch refs/heads/master from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7235aeb ] CB-12017 : removed updated npm version due to fails after rebasing from master This closes #517
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7235aeb0c6e4641bd858cd2e393e5552d8f229c9 in cordova-lib's branch refs/heads/common-2.0.x from Audrey So
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7235aeb ]

          CB-12017 : removed updated npm version due to fails after rebasing from master

          This closes #517

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7235aeb0c6e4641bd858cd2e393e5552d8f229c9 in cordova-lib's branch refs/heads/common-2.0.x from Audrey So [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7235aeb ] CB-12017 : removed updated npm version due to fails after rebasing from master This closes #517

            People

            • Assignee:
              auso Audrey So
              Reporter:
              stevegill Steve Gill
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development