Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11976

Add deprecated node version warning for 0.x

    Details

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/cordova-cli/pull/262

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/262
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9c306a44e146788dd6c62a9b3005212608e4572b in cordova-cli's branch refs/heads/master from Shazron Abdullah
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=9c306a4 ]

        CB-11976 - Updated package.json engine key

        This closes #262

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9c306a44e146788dd6c62a9b3005212608e4572b in cordova-cli's branch refs/heads/master from Shazron Abdullah [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=9c306a4 ] CB-11976 - Updated package.json engine key This closes #262
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0814fe06c7851103ea321873cd160b47481596cd in cordova-cli's branch refs/heads/master from Shazron Abdullah
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=0814fe0 ]

        CB-11976 - Add deprecated node version warning for 0.x

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0814fe06c7851103ea321873cd160b47481596cd in cordova-cli's branch refs/heads/master from Shazron Abdullah [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=0814fe0 ] CB-11976 - Add deprecated node version warning for 0.x
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron commented on the issue:

        https://github.com/apache/cordova-cli/pull/262

        @stevengill yes, it should be `>=4.0.0` and remove the `engineStrict` key as well. I'll add it soon

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/262 @stevengill yes, it should be `>=4.0.0` and remove the `engineStrict` key as well. I'll add it soon
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user stevengill commented on the issue:

        https://github.com/apache/cordova-cli/pull/262

        LGTM

        Should we update https://github.com/apache/cordova-cli/blob/master/package.json#L8 in this PR?

        Show
        githubbot ASF GitHub Bot added a comment - Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/262 LGTM Should we update https://github.com/apache/cordova-cli/blob/master/package.json#L8 in this PR?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron commented on the issue:

        https://github.com/apache/cordova-lib/pull/497

        @vladimir-kotikov good idea, I'll update it to >=4.0.0 since engineStrict is not used anymore in npm@3 – and we should remove engineStrict anyways. This PR has moved to https://github.com/apache/cordova-cli/pull/262

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 @vladimir-kotikov good idea, I'll update it to >=4.0.0 since engineStrict is not used anymore in npm@3 – and we should remove engineStrict anyways. This PR has moved to https://github.com/apache/cordova-cli/pull/262
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user shazron reopened a pull request:

        https://github.com/apache/cordova-cli/pull/262

        CB-11976 - Add deprecated node version warning for 0.x

            1. Platforms affected

        All.

            1. What does this PR do?

        Before running each command, it will check if the node version is 0.x. If it is, it prints out a warning.

            1. What testing has been done on this change?

        Tested locally.

            1. Checklist
        • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
        • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/shazron/cordova-cli CB-11976

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/cordova-cli/pull/262.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #262


        commit 0814fe06c7851103ea321873cd160b47481596cd
        Author: Shazron Abdullah <shazron@apache.org>
        Date: 2016-10-10T07:53:58Z

        CB-11976 - Add deprecated node version warning for 0.x


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user shazron reopened a pull request: https://github.com/apache/cordova-cli/pull/262 CB-11976 - Add deprecated node version warning for 0.x Platforms affected All. What does this PR do? Before running each command, it will check if the node version is 0.x. If it is, it prints out a warning. What testing has been done on this change? Tested locally. Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli CB-11976 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/262.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #262 commit 0814fe06c7851103ea321873cd160b47481596cd Author: Shazron Abdullah <shazron@apache.org> Date: 2016-10-10T07:53:58Z CB-11976 - Add deprecated node version warning for 0.x
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron closed the pull request at:

        https://github.com/apache/cordova-cli/pull/262

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron closed the pull request at: https://github.com/apache/cordova-cli/pull/262
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user vladimir-kotikov commented on the issue:

        https://github.com/apache/cordova-lib/pull/497

        @shazron, we still have `"node": ">=0.9.9"` in [package.json](https://github.com/apache/cordova-lib/blob/master/cordova-lib/package.json#L16). Might want to update it, so the users will see a warning at install time

        Show
        githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/497 @shazron, we still have `"node": ">=0.9.9"` in [package.json] ( https://github.com/apache/cordova-lib/blob/master/cordova-lib/package.json#L16 ). Might want to update it, so the users will see a warning at install time
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user shazron opened a pull request:

        https://github.com/apache/cordova-cli/pull/262

        CB-11976 - Add deprecated node version warning for 0.x

            1. Platforms affected

        All.

            1. What does this PR do?

        Before running each command, it will check if the node version is 0.x. If it is, it prints out a warning.

            1. What testing has been done on this change?

        Tested locally.

            1. Checklist
        • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
        • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/shazron/cordova-cli CB-11976

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/cordova-cli/pull/262.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #262


        commit 0814fe06c7851103ea321873cd160b47481596cd
        Author: Shazron Abdullah <shazron@apache.org>
        Date: 2016-10-10T07:53:58Z

        CB-11976 - Add deprecated node version warning for 0.x


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user shazron opened a pull request: https://github.com/apache/cordova-cli/pull/262 CB-11976 - Add deprecated node version warning for 0.x Platforms affected All. What does this PR do? Before running each command, it will check if the node version is 0.x. If it is, it prints out a warning. What testing has been done on this change? Tested locally. Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli CB-11976 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/262.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #262 commit 0814fe06c7851103ea321873cd160b47481596cd Author: Shazron Abdullah <shazron@apache.org> Date: 2016-10-10T07:53:58Z CB-11976 - Add deprecated node version warning for 0.x
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron commented on the issue:

        https://github.com/apache/cordova-lib/pull/497

        Closing. Can't have an effective warn in here, moving to cordova-cli.

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Closing. Can't have an effective warn in here, moving to cordova-cli.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron closed the pull request at:

        https://github.com/apache/cordova-lib/pull/497

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/497
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron commented on the issue:

        https://github.com/apache/cordova-lib/pull/497

        We have to print the warning out in the getPlatformAPI method, somewhere before this line: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/platforms/platforms.js#L46

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 We have to print the warning out in the getPlatformAPI method, somewhere before this line: https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/platforms/platforms.js#L46
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user shazron commented on the issue:

        https://github.com/apache/cordova-lib/pull/497

        Making a change so it is shown on every command, not just `prepare`

        Show
        githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Making a change so it is shown on every command, not just `prepare`
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user codecov-io commented on the issue:

        https://github.com/apache/cordova-lib/pull/497

          1. [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) is 80.41% (diff: 100%)
            > Merging 497(https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by *0.01%*

        ```diff
        @@ master #497 diff @@
        ==========================================
        Files 67 67
        Lines 5189 5192 +3
        Methods 836 836
        Messages 0 0
        Branches 1005 1006 +1
        ==========================================
        + Hits 4172 4175 +3
        Misses 1017 1017
        Partials 0 0
        ```

        > Powered by [Codecov](https://codecov.io?src=pr). Last update [4ca3b4c...65181b5](https://codecov.io/gh/apache/cordova-lib/compare/4ca3b4ca12a01ded923734e4d92d7f9325d540dc...65181b5b16f9cae3335e169bd8296e44a45aa4e7?src=pr)

        Show
        githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/497 [Current coverage] ( https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr ) is 80.41% (diff: 100%) > Merging 497 ( https://codecov.io/gh/apache/cordova-lib/pull/497?src=pr ) into [master] ( https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr ) will increase coverage by * 0.01% * ```diff @@ master #497 diff @@ ========================================== Files 67 67 Lines 5189 5192 +3 Methods 836 836 Messages 0 0 Branches 1005 1006 +1 ========================================== + Hits 4172 4175 +3 Misses 1017 1017 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last update [4ca3b4c...65181b5] ( https://codecov.io/gh/apache/cordova-lib/compare/4ca3b4ca12a01ded923734e4d92d7f9325d540dc...65181b5b16f9cae3335e169bd8296e44a45aa4e7?src=pr )
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user shazron opened a pull request:

        https://github.com/apache/cordova-lib/pull/497

        CB-11976 - Add deprecated node version warning for 0.x

        <!--
        Please make sure the checklist boxes are all checked before submitting the PR. The checklist
        is intended as a quick reference, for complete details please see our Contributor Guidelines:

        http://cordova.apache.org/contribute/contribute_guidelines.html

        Thanks!
        -->

            1. Platforms affected
              All
            1. What does this PR do?
              Prints out a warning on `prepare` that you are using a deprecated node version, if you are using any node version 0.x
            1. What testing has been done on this change?

        Tested locally.

            1. Checklist
        • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
        • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/shazron/cordova-lib CB-11976

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/cordova-lib/pull/497.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #497


        commit 19031e645c1a885728c81650b55189cc311d1e13
        Author: Shazron Abdullah <shazron@apache.org>
        Date: 2016-10-07T21:46:01Z

        CB-11976 - Add deprecated node version warning for 0.x


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/497 CB-11976 - Add deprecated node version warning for 0.x <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected All What does this PR do? Prints out a warning on `prepare` that you are using a deprecated node version, if you are using any node version 0.x What testing has been done on this change? Tested locally. Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11976 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #497 commit 19031e645c1a885728c81650b55189cc311d1e13 Author: Shazron Abdullah <shazron@apache.org> Date: 2016-10-07T21:46:01Z CB-11976 - Add deprecated node version warning for 0.x
        Hide
        shazron Shazron Abdullah added a comment -

        Only 0.10 and 0.12 users.
        I was thinking about that, do we want a flag? like "--no-warn-0.x-deprecation"?

        Show
        shazron Shazron Abdullah added a comment - Only 0.10 and 0.12 users. I was thinking about that, do we want a flag? like "--no-warn-0.x-deprecation"?
        Hide
        stevegill Steve Gill added a comment -

        are we okay bugging users on every prepare? Anyway to turn off the message?

        Show
        stevegill Steve Gill added a comment - are we okay bugging users on every prepare? Anyway to turn off the message?

          People

          • Assignee:
            shazron Shazron Abdullah
            Reporter:
            shazron Shazron Abdullah
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development