[CB-11933] [windows] uap: not added on plugin add

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-windows
• Assignee: Nikita Matrosov
• Reporter: Sergey Shakhnazarov
• Created: 29/Sep/16 10:00
• Updated: 23/Aug/18 06:51
• Resolved: 20/Oct/16 12:16

Description

cordova create test
cd test
cordova platform add https://github.com/apache/cordova-windows
cordova plugin add https://github.com/AzureAD/azure-activedirectory-library-for-cordova
cordova plugin add plugins\cordova-plugin-ms-adal\src\windows\sso\
type platforms\windows\package.windows10.appxmanifest

->

    <Capabilities>
        <Capability Name="internetClient" />
        <Capability Name="enterpriseAuthentication" />
        <Capability Name="privateNetworkClientServer" />
        <Capability Name="sharedUserCertificates" />
    </Capabilities>

cordova prepare

type platforms\windows\package.windows10.appxmanifest

    <Capabilities>
        <Capability Name="internetClient" />
        <uap:Capability Name="enterpriseAuthentication" />
        <Capability Name="privateNetworkClientServer" />
        <uap:Capability Name="sharedUserCertificates" />
    </Capabilities>

cordova plugin rm cordova-plugin-ms-adal-sso

type platforms\windows\package.windows10.appxmanifest

    <Capabilities>
        <Capability Name="internetClient" />
        <uap:Capability Name="enterpriseAuthentication" />
        <uap:Capability Name="sharedUserCertificates" />
    </Capabilities>

1. uap: prefixes not being added on plugin add
2. cordova prepare fixes this
3. plugin rm does not remove added capabilities as they have been changed

cordova-plugin-ms-adal-sso plugin.xml:

    <platform name="windows">
        <js-module name="overrides" src="www/overrides.js">
            <runs />
        </js-module>

        <config-file target="package.appxmanifest" parent="/Package/Capabilities" device-target="windows">
            <Capability Name="enterpriseAuthentication" />
            <Capability Name="privateNetworkClientServer" />
            <Capability Name="sharedUserCertificates" />
        </config-file>
    </platform>

Issue Links

• links to: GitHub Pull Request #202
• links to: GitHub Pull Request #203