Details

    Attachments

      Issue Links

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user lucatorella opened a pull request:

          https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18

          CB-11815: (iOS) Fix hard-coded bridge name "cordova"

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?
              1. What testing has been done on this change?
              1. Checklist
              1. Platforms affected
                iOS
              1. What does this PR do?
                Replaced hard coded string.
              1. What testing has been done on this change?
                No test necessary
              1. Checklist

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lucatorella/cordova-plugin-wkwebview-engine patch-1

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #18


          commit 7db0190f2e2689197fa30fb5f0d83eaad867a631
          Author: Luca Torella <lucatorella@gmail.com>
          Date: 2016-09-07T07:35:52Z

          CB-11815: (iOS) Fix hard-coded bridge name "cordova"

              1. Platforms affected
                iOS
              1. What does this PR do?
                Replaced hard coded string.
              1. What testing has been done on this change?
                No test necessary
              1. Checklist

          githubbot ASF GitHub Bot added a comment - GitHub user lucatorella opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18 CB-11815 : (iOS) Fix hard-coded bridge name "cordova" <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? What testing has been done on this change? Checklist [ ] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [ ] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. Platforms affected iOS What does this PR do? Replaced hard coded string. What testing has been done on this change? No test necessary Checklist [x] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lucatorella/cordova-plugin-wkwebview-engine patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit 7db0190f2e2689197fa30fb5f0d83eaad867a631 Author: Luca Torella <lucatorella@gmail.com> Date: 2016-09-07T07:35:52Z CB-11815 : (iOS) Fix hard-coded bridge name "cordova" Platforms affected iOS What does this PR do? Replaced hard coded string. What testing has been done on this change? No test necessary Checklist [x] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [x] Added automated test coverage as appropriate for this change.

          Commit a4f3e8848508ea8e12e03e168f6cf398400ede1c in cordova-plugin-wkwebview-engine's branch refs/heads/master from lucatorella
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=a4f3e88 ]

          CB-11815: (iOS) Fix hard-coded bridge name "cordova"

          This closes #18

          jira-bot ASF subversion and git services added a comment - Commit a4f3e8848508ea8e12e03e168f6cf398400ede1c in cordova-plugin-wkwebview-engine's branch refs/heads/master from lucatorella [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=a4f3e88 ] CB-11815 : (iOS) Fix hard-coded bridge name "cordova" This closes #18
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18

          People

            shazron Shazron Abdullah
            shazron Shazron Abdullah
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: