Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.2.1
-
None
-
ionic-framework 1.1
Android
Windows 10
Description
dialog prompt text color is not set. As a result the text appears invisible to the user.
I added c. line 290 in src\Notification.java in function prompt() to temporarily get around this problem
promptInput.setTextColor(0xff444444);
Attachments
Issue Links
- links to
Activity
Hi Kerri
I tested it on Android 6.1 on Samsung Galaxy 6.
I will try to get a sample project made, it shouldn't be too hard. But I
need your help as this is my first interaction on this forum - how does one
upload this kind of thing? Would it better as an APK or source code zip of
an ionic project?
Regards
Dinesh
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/81
CB-11677 android: fix bug with prompt text
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/81.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #81
commit dfad7945d8b8ee0dbf14fe4dc0a4530a0b86d027
Author: Nikita Matrosov <nikita.matrosov@rp.ru>
Date: 2016-08-09T12:52:03Z
CB-11677 android: fix bug with prompt text
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
Cordova CI Build has completed successfully.
*Commit* - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/dfad7945d8b8ee0dbf14fe4dc0a4530a0b86d027)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/24/)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/81#discussion_r74416632
— Diff: src/android/Notification.java —
@@ -286,7 +286,9 @@ public synchronized void prompt(final String message, final String title, final
Runnable runnable = new Runnable() {
public void run() {
final EditText promptInput = new EditText(cordova.getActivity());
- promptInput.setHint(defaultText);
+ final int promptInputColor = 0xff444444;-
- End diff –
-
@matrosovN, i think you should avoid using 'magic' numbers. IMO this value should be read from resources, rather than hardcoded.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
Cordova CI Build has one or more failures.
*Commit* - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/24b6dcbac3da6437d32a30e9cf39fa5d0c29180b)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/25/)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
Cordova CI Build has one or more failures.
*Commit* - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/d361ad9a81dce08b13c4c8b153ed272bda160dce)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/26/)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
Cordova CI Build has completed successfully.
*Commit* - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/a5b4aa12d9bff94f444f44e46e5736690fbd7ef6)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/27/)
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
LGTM
Commit 7c4a5de3ad965fc4830c98610afc4e05968db803 in cordova-plugin-dialogs's branch refs/heads/master from Nikita Matrosov
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=7c4a5de ]
CB-11677 Android: made text, entered to prompt dialog visible
CB-11214 Android: set default text instead of hint in prompt text field
This closes #81
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
Cordova CI Build has one or more failures.
*Commit* - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/44ee9952a90ea46f7ef449b03aca23fca52721db)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/28/)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/81
Cordova CI Build has one or more failures.
*Commit* - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/81/commits/2211ee6684670b19f7b1002305f221cc6fd5e8e6)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-dialogs-pr/29/)
It would be great if you could create a sample project that duplicates this behavior and share a link to it so that we can easily duplicate the behavior you are seeing. I'm also curious what Android version(s) you've verified this on.
For whomever picks up this bug to work on it: the color shouldn't be a magic value.