Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11667

Memory leak in CDVContact for CoreFoundation ABRecordRef

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • iOS

    Description

      See https://github.com/apache/cordova-plugin-contacts/pull/35

      Fix:
      1. create a dealloc method
      2. Add the CFRelease there

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user shazron opened a pull request:

            https://github.com/apache/cordova-plugin-contacts/pull/132

            CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef

            Related to https://github.com/apache/cordova-plugin-contacts/pull/35

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/shazron/cordova-plugin-contacts CB-11667

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-contacts/pull/132.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #132


            commit 226a7f1041fc3517f556d6cc5eb9068d49bc5fcf
            Author: Shazron Abdullah <shazron@apache.org>
            Date: 2016-08-04T00:49:40Z

            CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef


            githubbot ASF GitHub Bot added a comment - GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/132 CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef Related to https://github.com/apache/cordova-plugin-contacts/pull/35 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-contacts CB-11667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit 226a7f1041fc3517f556d6cc5eb9068d49bc5fcf Author: Shazron Abdullah <shazron@apache.org> Date: 2016-08-04T00:49:40Z CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef
            githubbot ASF GitHub Bot added a comment -

            Github user cordova-qa commented on the issue:

            https://github.com/apache/cordova-plugin-contacts/pull/132

            Cordova CI Build has completed successfully.

            *Commit* - [Link](https://github.com/apache/cordova-plugin-contacts/pull/132/commits/226a7f1041fc3517f556d6cc5eb9068d49bc5fcf)
            *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35/)

            Builder Name Console Output Test Report Device Logs
            :---: :---: :---: :---:
            [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/artifact/)
            [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/artifact/)
            [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/artifact/)
            [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/artifact/)
            [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/artifact/)
            githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/132 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-contacts/pull/132/commits/226a7f1041fc3517f556d6cc5eb9068d49bc5fcf ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/35//PLATFORM=android/artifact/ )
            githubbot ASF GitHub Bot added a comment -

            Github user lboekhorst commented on the issue:

            https://github.com/apache/cordova-plugin-contacts/pull/132

            Awesome, thanks for this!

            githubbot ASF GitHub Bot added a comment - Github user lboekhorst commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/132 Awesome, thanks for this!

            Commit c7c69d59cd8e5ab5ee97f6a2f535ad30653d6588 in cordova-plugin-contacts's branch refs/heads/master from shazron
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=c7c69d5 ]

            CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef

            This closes #132

            jira-bot ASF subversion and git services added a comment - Commit c7c69d59cd8e5ab5ee97f6a2f535ad30653d6588 in cordova-plugin-contacts's branch refs/heads/master from shazron [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=c7c69d5 ] CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef This closes #132
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-contacts/pull/132

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/132

            People

              shazron Shazron Abdullah
              shazron Shazron Abdullah
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: