[CB-11636] Merging config.xml w/ attributes containing " fails.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.4.1
• Component/s: cordova-common
• Labels: reproduced triaged xml
• Assignee: Vladimir Kotikov
• Reporter: Vladimir Kotikov
• Created: 28/Jul/16 10:46
• Updated: 23/Aug/18 06:58
• Resolved: 02/Aug/16 06:33

Description

Repro steps:

• Create an empty project
• Add <preference name="name" value="my "quoted" value"> to config.xml (notice that JIRA replaces " by " symbol)
• Add any of ios, windows or android platform
• Call cordova prepare

Expected:
prepare succeds and preference copied to platform's config.xml

Actual:
prepare fails with unrelevant stacktrace:

No scripts found for hook "before_prepare".
Checking config.xml for saved platforms that haven't been added to the project
Checking for any plugins added to the project that have not been installed in android platform
No differences found between plugins added to project and installed in android platform. Continuing...
Generating config.xml from defaults for platform "android"
net.js:647
    throw new TypeError(
    ^

TypeError: Invalid data, chunk must be a string or buffer, not undefined
    at WriteStream.Socket.write (net.js:647:11)
    at WriteStream.stream.write (D:\cordova\cordova-lib\cordova-common\node_modules\ansi\lib\newlines.js:36:21)
    at Cursor.write (D:\cordova\cordova-lib\cordova-common\node_modules\ansi\lib\ansi.js:157:23)
    at CordovaLogger.log (D:\cordova\cordova-lib\cordova-common\src\CordovaLogger.js:102:12)
    at process.<anonymous> (D:\cordova\cordova-cli\src\cli.js:253:16)
    at emitOne (events.js:96:13)
    at process.emit (events.js:188:7)
    at process._fatalException (bootstrap_node.js:254:26)

Issue Links

• breaks: CB-11613 &quote; in WindowsStorePublisherName leads to "Invalid attribute predicate"
• links to: GitHub Pull Request #470