Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11607

breakout cordova-create from cordova-lib

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-create
    • Labels:
      None

      Description

      As the title suggests, lets breakout cordova-create from cordova-lib and publish it as its own module. It can live in the cordova-lib git repo.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-cli/pull/259

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/259
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ddd828f493c8059fd29827d2f54ce680ce904a60 in cordova-cli's branch refs/heads/master from Caryn Tran
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=ddd828f ]

          CB-11607 breakout cordova-create from cordova-lib; CB-11623 added back linking

          This closes #259

          Show
          jira-bot ASF subversion and git services added a comment - Commit ddd828f493c8059fd29827d2f54ce680ce904a60 in cordova-cli's branch refs/heads/master from Caryn Tran [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=ddd828f ] CB-11607 breakout cordova-create from cordova-lib; CB-11623 added back linking This closes #259
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-lib/pull/478

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/478
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4c4521dc3fd5ca65489560cc8243e19883254070 in cordova-lib's branch refs/heads/master from Caryn Tran
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4c4521d ]

          CB-11607 breakout cordova-create from cordova-lib

          CB-11412 aliased copy-from to template; added support for www template

          This closes #478

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4c4521dc3fd5ca65489560cc8243e19883254070 in cordova-lib's branch refs/heads/master from Caryn Tran [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4c4521d ] CB-11607 breakout cordova-create from cordova-lib CB-11412 aliased copy-from to template; added support for www template This closes #478
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user stevengill commented on the issue:

          https://github.com/apache/cordova-lib/pull/478

          Looks like this fails because cordova-create removes all listeners on events.

          Show
          githubbot ASF GitHub Bot added a comment - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/478 Looks like this fails because cordova-create removes all listeners on events.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user carynbear commented on the issue:

          https://github.com/apache/cordova-lib/pull/478

          Not passing tests (with plugins? and platforms?)

          Show
          githubbot ASF GitHub Bot added a comment - Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/478 Not passing tests (with plugins? and platforms?)
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user carynbear opened a pull request:

          https://github.com/apache/cordova-cli/pull/259

          CB-11607 breakout cordova-create from cordova-lib

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/carynbear/cordova-cli decouple

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-cli/pull/259.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #259


          commit 554ddeb391b28ffdcfc5acca988d32ac99d20fd6
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-07-01T23:50:57Z

          fetch argument removed, eventemitter arg added to create call

          commit a501197279b48373eb19a4cf3c19a20bda6670c3
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-07-16T00:29:34Z

          fix custom www asset local logic

          commit 4909cd8a856bc51972c6885348c7eef049c11cb2
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-08-04T18:41:43Z

          CB-11623 added back linking

          commit ff0a8f2f4afa6f650a8f00472129420d04b6f329
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-08-11T22:46:46Z

          changed package.json


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user carynbear opened a pull request: https://github.com/apache/cordova-cli/pull/259 CB-11607 breakout cordova-create from cordova-lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-cli decouple Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/259.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #259 commit 554ddeb391b28ffdcfc5acca988d32ac99d20fd6 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-07-01T23:50:57Z fetch argument removed, eventemitter arg added to create call commit a501197279b48373eb19a4cf3c19a20bda6670c3 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-07-16T00:29:34Z fix custom www asset local logic commit 4909cd8a856bc51972c6885348c7eef049c11cb2 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-08-04T18:41:43Z CB-11623 added back linking commit ff0a8f2f4afa6f650a8f00472129420d04b6f329 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-08-11T22:46:46Z changed package.json
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user carynbear opened a pull request:

          https://github.com/apache/cordova-lib/pull/478

          CB-11607 breakout cordova-create from cordova-lib

          Waiting on [cordova-create](https://github.com/apache/cordova-create) release on npm.
          Will need to update package.json.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/carynbear/cordova-lib decouple

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/478.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #478


          commit 5fcb728675187ff18422fc45ed4da8fec0fadebf
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-06-21T19:52:33Z

          detached create; not yet npm published

          commit a1396fa0c3e1bde1948ff28ebe9d83e599324f5b
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-06-24T23:35:49Z

          CB-11412 removed link-to; aliased copy-from to template; added support for www template

          commit 17c01cb114c350789b74f7d62b023f422a9f1f72
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-07-13T00:35:40Z

          cordova create test moves config.xml to project root; mute events for testing

          commit c6fd0dee1562d77eed87ddaa7cb8d804f05f998e
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-07-20T22:38:08Z

          cordova-create moved to its own repo

          commit 194debeadd33505313a5388a317a1d86a64405a9
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-08-01T22:09:04Z

          package.json create points to carynbear repo

          commit 3004daf29f69432eed003e137a3f5ffda57f4cf9
          Author: carynbear <caryn.tran@berkeley.edu>
          Date: 2016-08-04T23:43:22Z

          updated package.json; removed tests from create (mostly in cordova-create now)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/478 CB-11607 breakout cordova-create from cordova-lib Waiting on [cordova-create] ( https://github.com/apache/cordova-create ) release on npm. Will need to update package.json. You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-lib decouple Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #478 commit 5fcb728675187ff18422fc45ed4da8fec0fadebf Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-21T19:52:33Z detached create; not yet npm published commit a1396fa0c3e1bde1948ff28ebe9d83e599324f5b Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-24T23:35:49Z CB-11412 removed link-to; aliased copy-from to template; added support for www template commit 17c01cb114c350789b74f7d62b023f422a9f1f72 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-07-13T00:35:40Z cordova create test moves config.xml to project root; mute events for testing commit c6fd0dee1562d77eed87ddaa7cb8d804f05f998e Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-07-20T22:38:08Z cordova-create moved to its own repo commit 194debeadd33505313a5388a317a1d86a64405a9 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-08-01T22:09:04Z package.json create points to carynbear repo commit 3004daf29f69432eed003e137a3f5ffda57f4cf9 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-08-04T23:43:22Z updated package.json; removed tests from create (mostly in cordova-create now)
          Show
          stevegill Steve Gill added a comment - proposal: https://github.com/cordova/cordova-discuss/pull/51

            People

            • Assignee:
              carynbear Caryn Tran
              Reporter:
              stevegill Steve Gill
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development