[CB-11535] Logic error in uninstall frameworks in iOS

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-ios
• Assignee: Shazron Abdullah
• Reporter: Shazron Abdullah
• Created: 05/Jul/16 06:06
• Updated: 23/Aug/18 06:56
• Resolved: 02/Aug/16 06:29

Description

This is reference counting code.

Line: https://github.com/apache/cordova-ios/blob/5c3885b807f4c9556bf350c72400827a333f78d3/bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js#L100

project.frameworks[src] -= (project.frameworks[src] || 1) - 1;

which expands to:

project.frameworks[src] = project.frameworks[src] - (project.frameworks[src] || 1) - 1;

project.frameworks[src] would contain a number, or undefined.

My guess is that the intent of this line is to decrement the reference count by 1. If the count was not set, the resulting count value should be negative, according to the next conditional "if (project.frameworks[src] < 1)

{" where it would delete the entry in the object. The correct line should be: {code}

project.frameworks[src] = (project.frameworks[src] || 1) - 1;

Issue Links

• is related to: CB-10361 frameworks.json not being updated properly
• links to: GitHub Pull Request #238