GitHub user daserge opened a pull request:

https://github.com/apache/cordova-docs/pull/616

CB-11491 Introduce before_deploy hook

[Jira issue](https://issues.apache.org/jira/browse/CB-11491)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-docs CB-11491

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #616

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-lib/pull/460

CB-11491 Introduce before_deploy hook

Updated tests

[Jira issue](https://issues.apache.org/jira/browse/CB-11491)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-lib CB-11491

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #460

commit ee8b5f8a9beca359c37f4b0f6ceedec071a5d28f
Author: daserge <v-seshak@microsoft.com>
Date: 2016-06-30T12:38:54Z

CB-11491 Introduce before_deploy hook
Updated tests

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/460

1. 1. [Current coverage][cc-pull] is *80.63%*
      > Merging 460[cc-pull] into [master][cc-base-branch] will increase coverage by *0.04%*

```diff
@@ master #460 diff @@
==========================================
Files 68 68
Lines 5380 5392 +12
Methods 851 855 +4
Messages 0 0
Branches 1038 1038
==========================================
+ Hits 4336 4348 +12
Misses 1044 1044
Partials 0 0
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [e810685...ee8b5f8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/e810685ce42a6615d62117f026316c9931ad8707...ee8b5f8a9beca359c37f4b0f6ceedec071a5d28f
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/460?src=pr

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/460#discussion_r69436735

— Diff: cordova-lib/spec-cordova/emulate.spec.js —
@@ -82,7 +85,7 @@ describe('emulate command', function() {
cordova.raw.emulate({platforms: ['ios'], options: {optionTastic: true }}).then(function(err) {
expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining(

));
expect(getPlatformApi).toHaveBeenCalledWith('ios');

• expect(platformApi.run).toHaveBeenCalledWith( { device: false, emulator: true, optionTastic: true }

  );
  + expect(platformApi.run).toHaveBeenCalledWith(

  { device: false, emulator: true, optionTastic: true, nobuild: true }

  );

  • • End diff –

@daserge, could you please add another expectation to check if `build` also had been called and changing the options in `build` does not affect `run` command?

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/460#discussion_r69436760

— Diff: cordova-lib/spec-cordova/run.spec.js —
@@ -79,7 +82,7 @@ describe('run command', function() {
it('should pass down parameters', function(done) {
cordova.raw.run({platforms: ['blackberry10'], options:{password: '1q1q'}}).then(function() {
expect(prepare_spy).toHaveBeenCalledWith({ platforms: [ 'blackberry10' ], options:

, verbose: false });

• expect(platformApi.run).toHaveBeenCalledWith( {password: '1q1q'}

  );
  + expect(platformApi.run).toHaveBeenCalledWith(

  {password: '1q1q', nobuild: true}

  );

  • • End diff –

Same here

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/460

Some minor comments, LGTM otherwise

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/460

LGTM

Commit 7d367dcb01740450e0af447308c0b859616e709d in cordova-lib's branch refs/heads/master from Sergey Shakhnazarov
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=7d367dc ]

CB-11491 Introduce before_deploy hook

This closes #460

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/460

Commit 88fdf05115afc3d36fe6268e8e7bb347b400ddd5 in cordova-docs's branch refs/heads/master from Sergey Shakhnazarov
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=88fdf05 ]

CB-11491 Introduce before_deploy hook

This closes #616

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/616