[CB-11474] protocol launch fails due to splash null reference

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.1.1
• Component/s: cordova-windows
• Labels: crash protocol-launch splash windows windows-4.4.0

Environment

Windows Platform Version: 4.4.0
OS: Windows 10
Compiled with Visual Studio Community Edition 2015
Run on PC as a Windows App

• Assignee: Unassigned
• Reporter: Doan Isakov
• Created: 23/Jun/16 09:40
• Updated: 23/Aug/18 06:56
• Resolved: 12/Jul/16 15:54

Description

When the app launch in Windows is triggered using a custom URL (Protocol Declaration), the app crashes. As far as I could see, the reason seems to be a null reference for the system splash screen. The following occurs in cordova.js:

1. The function activated is called
   cordova.js

   function activated(eventObject) {
       if (eventObject.detail.kind === Windows.ApplicationModel.Activation.ActivationKind.launch) {
           // Retrieve splash screen object 
           splash = eventObject.detail.splashScreen;
   

2. It does not set the splash screen because the launch is Windows.ApplicationModel.Activation.ActivationKind.protocol
3. The function positionControls is called and it access the splash object
   cordova.js

   function positionControls() {
       ...
       ...
   
       // Position the extended splash screen image in the same location as the system splash screen image.
       if (isPhone) {
           extendedSplashImage.style.top = 0;
           extendedSplashImage.style.left = 0;
           centerY();
       } else {
           extendedSplashImage.style.top = splash.imageLocation.y + 'px';
   

4. The app crashes

Issue Links

• relates to: CB-11470 App crashes when trying to open from another app using Custom URL (Protocol)