GitHub user hollyschinsky opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/184
CB-11407 (ios): Added extern keyword to constants to fix phonegap-webview-ios template projects
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
-
-
- Platforms affected
iOS
-
-
- What does this PR do?
Fixes iOS embedded webview projects based on the [phonegap-webview-ios template](https://github.com/phonegap/phonegap-webview-ios/) due to the reasons explained in CB-11407(https://issues.apache.org/jira/browse/CB-11407) and template [issue 8] (https://github.com/phonegap/phonegap-webview-ios/issues/8).
-
-
- What testing has been done on this change?
This change has been tested locally with iOS embedded webview projects based on [this template](https://github.com/phonegap/phonegap-webview-ios).
-
-
- Checklist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hollyschinsky/cordova-plugin-file embed-webview-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
commit 8d7191d8e6ab4187b58144e80299db0c8490afe2
Author: Holly Schinsky <hollyschinsky@gmail.com>
Date: 2016-06-09T21:05:45Z
CB-11407 ios: added extern keyword to constants to fix phonegap-webview-ios template issue.
GitHub user hollyschinsky opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/184
CB-11407(ios): Added extern keyword to constants to fix phonegap-webview-ios template projects<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
iOS
Fixes iOS embedded webview projects based on the [phonegap-webview-ios template](https://github.com/phonegap/phonegap-webview-ios/) due to the reasons explained in
CB-11407(https://issues.apache.org/jira/browse/CB-11407) and template [issue 8] (https://github.com/phonegap/phonegap-webview-ios/issues/8).This change has been tested locally with iOS embedded webview projects based on [this template](https://github.com/phonegap/phonegap-webview-ios).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hollyschinsky/cordova-plugin-file embed-webview-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
commit 8d7191d8e6ab4187b58144e80299db0c8490afe2
Author: Holly Schinsky <hollyschinsky@gmail.com>
Date: 2016-06-09T21:05:45Z
CB-11407ios: added extern keyword to constants to fix phonegap-webview-ios template issue.