Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11407

Duplicate Symbol error in iOS Embedded Webview template projects

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • cordova-plugin-file
    • None
    • IOS

    Description

      When creating projects using the iOS embedded webview template with a version of CocoaPods > 0.39, you will receive a duplicate symbols for architecture x86_64 error. Details about the issue and fix are all included here.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user hollyschinsky opened a pull request:

            https://github.com/apache/cordova-plugin-file/pull/184

            CB-11407 (ios): Added extern keyword to constants to fix phonegap-webview-ios template projects

            <!--
            Please make sure the checklist boxes are all checked before submitting the PR. The checklist
            is intended as a quick reference, for complete details please see our Contributor Guidelines:

            http://cordova.apache.org/contribute/contribute_guidelines.html

            Thanks!
            -->

                1. Platforms affected
                  iOS
                1. What does this PR do?
                  Fixes iOS embedded webview projects based on the [phonegap-webview-ios template](https://github.com/phonegap/phonegap-webview-ios/) due to the reasons explained in CB-11407(https://issues.apache.org/jira/browse/CB-11407) and template [issue 8] (https://github.com/phonegap/phonegap-webview-ios/issues/8).
                1. What testing has been done on this change?
                  This change has been tested locally with iOS embedded webview projects based on [this template](https://github.com/phonegap/phonegap-webview-ios).
                1. Checklist

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/hollyschinsky/cordova-plugin-file embed-webview-fix

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-file/pull/184.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #184


            commit 8d7191d8e6ab4187b58144e80299db0c8490afe2
            Author: Holly Schinsky <hollyschinsky@gmail.com>
            Date: 2016-06-09T21:05:45Z

            CB-11407 ios: added extern keyword to constants to fix phonegap-webview-ios template issue.


            githubbot ASF GitHub Bot added a comment - GitHub user hollyschinsky opened a pull request: https://github.com/apache/cordova-plugin-file/pull/184 CB-11407 (ios): Added extern keyword to constants to fix phonegap-webview-ios template projects <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected iOS What does this PR do? Fixes iOS embedded webview projects based on the [phonegap-webview-ios template] ( https://github.com/phonegap/phonegap-webview-ios/ ) due to the reasons explained in CB-11407 ( https://issues.apache.org/jira/browse/CB-11407 ) and template [issue 8] ( https://github.com/phonegap/phonegap-webview-ios/issues/8 ). What testing has been done on this change? This change has been tested locally with iOS embedded webview projects based on [this template] ( https://github.com/phonegap/phonegap-webview-ios ). Checklist [X] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hollyschinsky/cordova-plugin-file embed-webview-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit 8d7191d8e6ab4187b58144e80299db0c8490afe2 Author: Holly Schinsky <hollyschinsky@gmail.com> Date: 2016-06-09T21:05:45Z CB-11407 ios: added extern keyword to constants to fix phonegap-webview-ios template issue.
            githubbot ASF GitHub Bot added a comment -

            Github user cordova-qa commented on the issue:

            https://github.com/apache/cordova-plugin-file/pull/184

            Cordova CI Build has one or more failures.

            *Commit* - [Link](https://github.com/apache/cordova-plugin-file/pull/184/commits/master)
            *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22/)

            Builder Name Console Output Test Report Device Logs
            :---: :---: :---: :---:
            [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/artifact/)
            [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/artifact/)
            [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/artifact/)
            [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/artifact/)
            [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/artifact/)
            githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/184 Cordova CI Build has one or more failures. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-file/pull/184/commits/master ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/22//PLATFORM=android/artifact/ )
            githubbot ASF GitHub Bot added a comment -

            Github user shazron commented on the issue:

            https://github.com/apache/cordova-plugin-file/pull/184

            Since the Cordova CI Build failure was for Android, and this change was for iOS, I would ignore the false positive. (seems to be a config problem? "ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?")

            githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-file/pull/184 Since the Cordova CI Build failure was for Android, and this change was for iOS, I would ignore the false positive. (seems to be a config problem? "ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?")

            Commit 8d7191d8e6ab4187b58144e80299db0c8490afe2 in cordova-plugin-file's branch refs/heads/master from hollyschinsky
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=8d7191d ]

            CB-11407 ios: added extern keyword to constants to fix phonegap-webview-ios template issue.

            jira-bot ASF subversion and git services added a comment - Commit 8d7191d8e6ab4187b58144e80299db0c8490afe2 in cordova-plugin-file's branch refs/heads/master from hollyschinsky [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=8d7191d ] CB-11407 ios: added extern keyword to constants to fix phonegap-webview-ios template issue.
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-file/pull/184

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/184

            People

              hollyschinsky Holly Schinsky
              hollyschinsky Holly Schinsky
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: